Code Review for open

Prepared by:sangheki on Sat Sep 21 06:25:38 PDT 2019
Workspace:/export/users/sangheki/ws/jdk/jdk3/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56322
Summary of changes: 1204 lines changed: 1090 ins; 9 del; 105 mod; 43666 unchg
Patch of changes: open.patch
Bug id: JDK-8220310 : Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
4 lines changed: 4 ins; 0 del; 0 mod; 3840 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
18 lines changed: 18 ins; 0 del; 0 mod; 6359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
0 lines changed: 0 ins; 0 del; 0 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 4 ins; 0 del; 1 mod; 5414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
2 lines changed: 2 ins; 0 del; 0 mod; 5730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
6 lines changed: 2 ins; 0 del; 4 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
12 lines changed: 6 ins; 0 del; 6 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
36 lines changed: 28 ins; 0 del; 8 mod; 495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
12 lines changed: 5 ins; 0 del; 7 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.inline.hpp

rev 56323 : imported patch 8220310.mut.0
12 lines changed: 4 ins; 0 del; 8 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.cpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
10 lines changed: 10 ins; 0 del; 0 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
22 lines changed: 8 ins; 1 del; 13 mod; 4758 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
13 lines changed: 9 ins; 1 del; 3 mod; 1480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
21 lines changed: 15 ins; 0 del; 6 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
8 lines changed: 3 ins; 0 del; 5 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
46 lines changed: 37 ins; 0 del; 9 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 7 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
7 lines changed: 7 ins; 0 del; 0 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
3 lines changed: 2 ins; 0 del; 1 mod; 897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 5 ins; 0 del; 0 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
78 lines changed: 63 ins; 0 del; 15 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
19 lines changed: 6 ins; 7 del; 6 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
4 lines changed: 4 ins; 0 del; 0 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
69 lines changed: 69 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 0 ins; 0 del; 5 mod; 518 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
3 lines changed: 0 ins; 0 del; 3 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/concurrentGCThread.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
0 lines changed: 0 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
0 lines changed: 0 ins; 0 del; 0 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logPrefix.hpp

rev 56323 : imported patch 8220310.mut.0
1 line changed: 1 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

rev 56323 : imported patch 8220310.mut.0
1 line changed: 1 ins; 0 del; 0 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
25 lines changed: 25 ins; 0 del; 0 mod; 2399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
2 lines changed: 0 ins; 0 del; 2 mod; 4310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
7 lines changed: 7 ins; 0 del; 0 mod; 1005 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_freeRegionList.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/sun/hotspot/WhiteBox.java

rev 56323 : imported patch 8220310.mut.0
3 lines changed: 3 ins; 0 del; 0 mod; 554 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1NUMA.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1NUMA.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1NUMA.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java

rev 56326 : [mq]: 8220310.mut.1-3_kim
219 lines changed: 219 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/sangheki/010_scripts/webrev.ksh (vers 25.18-hg+openjdk.java.net).