Code Review for open

Prepared by:sangheki on Sat Sep 21 06:27:09 PDT 2019
Workspace:/export/users/sangheki/ws/jdk/jdk3/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56323
Summary of changes: 1491 lines changed: 207 ins; 1088 del; 196 mod; 43378 unchg
Patch of changes: open.patch
Bug id: JDK-8220310 : Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 0 ins; 3 del; 2 mod; 3842 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
78 lines changed: 2 ins; 65 del; 11 mod; 6364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
12 lines changed: 0 ins; 12 del; 0 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 1 ins; 6 del; 2 mod; 5416 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
2 lines changed: 0 ins; 0 del; 2 mod; 5730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
2 lines changed: 0 ins; 1 del; 1 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 1 ins; 2 del; 2 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
1 line changed: 0 ins; 0 del; 1 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
2 lines changed: 0 ins; 1 del; 1 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.cpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
10 lines changed: 10 ins; 0 del; 0 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 1 ins; 2 del; 6 mod; 4772 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
8 lines changed: 3 ins; 3 del; 2 mod; 1487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
40 lines changed: 0 ins; 28 del; 12 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
24 lines changed: 7 ins; 9 del; 8 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1NUMA.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
267 lines changed: 37 ins; 210 del; 20 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1NUMA.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
102 lines changed: 12 ins; 70 del; 20 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1NUMA.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
31 lines changed: 13 ins; 8 del; 10 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
20 lines changed: 15 ins; 0 del; 5 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 3 ins; 0 del; 6 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
32 lines changed: 4 ins; 14 del; 14 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
14 lines changed: 7 ins; 0 del; 7 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
7 lines changed: 5 ins; 0 del; 2 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
3 lines changed: 2 ins; 0 del; 1 mod; 897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 5 ins; 0 del; 0 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
64 lines changed: 38 ins; 6 del; 20 mod; 556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 6 ins; 0 del; 3 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
2 lines changed: 0 ins; 1 del; 1 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
95 lines changed: 30 ins; 53 del; 12 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
5 lines changed: 0 ins; 4 del; 1 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
1 line changed: 0 ins; 1 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/concurrentGCThread.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
3 lines changed: 1 ins; 2 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
6 lines changed: 1 ins; 2 del; 3 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
1 line changed: 0 ins; 0 del; 1 mod; 2423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
1 line changed: 0 ins; 0 del; 1 mod; 4311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56326 : [mq]: 8220310.mut.1-3_kim
9 lines changed: 0 ins; 6 del; 3 mod; 1009 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_freeRegionList.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java (was test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchPages.java)

rev 56326 : [mq]: 8220310.mut.1-3_kim
57 lines changed: 3 ins; 39 del; 15 mod; 201 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1MemoryTouchThread.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
360 lines changed: 0 ins; 360 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1MemoryTouchThread.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1PageBasedNUMAVirtualSpace.cpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56325 : imported patch 8220310.mut.1-2_stefan
rev 56326 : [mq]: 8220310.mut.1-3_kim
60 lines changed: 0 ins; 60 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1PageBasedNUMAVirtualSpace.hpp

rev 56323 : imported patch 8220310.mut.0
rev 56324 : imported patch 8220310.mut.1_thomas
rev 56326 : [mq]: 8220310.mut.1-3_kim
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

This code review page was prepared using /home/sangheki/010_scripts/webrev.ksh (vers 25.18-hg+openjdk.java.net).