Code Review for open

Prepared by:sangheki on Tue Oct 8 20:03:52 PDT 2019
Workspace:/export/users/sangheki/ws/jdk/jdk3/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56450
Summary of changes: 720 lines changed: 220 ins; 418 del; 82 mod; 37355 unchg
Patch of changes: open.patch
Bug id: JDK-8220310 : Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56453 : [mq]: 8220310.mut.3-kim
1 line changed: 0 ins; 0 del; 1 mod; 3814 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3-thomas
rev 56453 : [mq]: 8220310.mut.3-kim
5 lines changed: 0 ins; 0 del; 5 mod; 6372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56453 : [mq]: 8220310.mut.3-kim
1 line changed: 0 ins; 0 del; 1 mod; 5418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3-thomas
rev 56453 : [mq]: 8220310.mut.3-kim
3 lines changed: 2 ins; 0 del; 1 mod; 5725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
4 lines changed: 2 ins; 0 del; 2 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
2 lines changed: 2 ins; 0 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.inline.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
rev 56453 : [mq]: 8220310.mut.3-kim
2 lines changed: 0 ins; 0 del; 2 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
3 lines changed: 0 ins; 2 del; 1 mod; 4795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
1 line changed: 1 ins; 0 del; 0 mod; 1493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
rev 56452 : [mq]: 8220310.mut.3-stefan
rev 56453 : [mq]: 8220310.mut.3-kim
172 lines changed: 134 ins; 14 del; 24 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryNodeManager.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
rev 56453 : [mq]: 8220310.mut.3-kim
25 lines changed: 14 ins; 2 del; 9 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
23 lines changed: 8 ins; 11 del; 4 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
5 lines changed: 3 ins; 1 del; 1 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
8 lines changed: 8 ins; 0 del; 0 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
1 line changed: 0 ins; 1 del; 0 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
1 line changed: 1 ins; 0 del; 0 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 56449 : imported patch 8220310.mut.1
rev 56452 : [mq]: 8220310.mut.3-stefan
rev 56453 : [mq]: 8220310.mut.3-kim
7 lines changed: 5 ins; 0 del; 2 mod; 898 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

49 lines changed: 2 ins; 41 del; 6 mod; 619 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.inline.hpp

11 lines changed: 2 ins; 9 del; 0 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logPrefix.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56450 : imported patch 8220310.mut.2
rev 56453 : [mq]: 8220310.mut.3-kim
1 line changed: 0 ins; 1 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56453 : [mq]: 8220310.mut.3-kim
8 lines changed: 0 ins; 3 del; 5 mod; 4296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56453 : [mq]: 8220310.mut.3-kim
5 lines changed: 0 ins; 3 del; 2 mod; 1007 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java

rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56452 : [mq]: 8220310.mut.3-stefan
rev 56453 : [mq]: 8220310.mut.3-kim
54 lines changed: 36 ins; 2 del; 16 mod; 193 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1NUMA.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
154 lines changed: 0 ins; 154 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1NUMA.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
106 lines changed: 0 ins; 106 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1NUMA.inline.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3-thomas
68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

This code review page was prepared using /home/sangheki/010_scripts/webrev.ksh (vers 25.18-hg+openjdk.java.net).