Code Review for open

Prepared by:sangheki on Fri Oct 25 13:48:41 PDT 2019
Workspace:/export/users/sangheki/ws/jdk/jdk3/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56447
Summary of changes: 999 lines changed: 911 ins; 13 del; 75 mod; 43666 unchg
Patch of changes: open.patch
Bug id: JDK-8220310 : Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
4 lines changed: 4 ins; 0 del; 0 mod; 3811 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
17 lines changed: 17 ins; 0 del; 0 mod; 6359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
0 lines changed: 0 ins; 0 del; 0 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
5 lines changed: 4 ins; 0 del; 1 mod; 5414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
4 lines changed: 4 ins; 0 del; 0 mod; 5724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
6 lines changed: 2 ins; 0 del; 4 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56452 : [mq]: 8220310.mut.4
12 lines changed: 6 ins; 0 del; 6 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
40 lines changed: 31 ins; 0 del; 9 mod; 494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
19 lines changed: 10 ins; 0 del; 9 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Allocator.inline.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
16 lines changed: 8 ins; 0 del; 8 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.cpp

rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
0 lines changed: 0 ins; 0 del; 0 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
37 lines changed: 24 ins; 1 del; 12 mod; 4760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
12 lines changed: 10 ins; 0 del; 2 mod; 1482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
rev 56454 : [mq]: 8220310.mut.6
5 lines changed: 5 ins; 0 del; 0 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
6 lines changed: 4 ins; 2 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
28 lines changed: 16 ins; 0 del; 12 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56453 : [mq]: 8220310.mut.5
2 lines changed: 2 ins; 0 del; 0 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
0 lines changed: 0 ins; 0 del; 0 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
13 lines changed: 11 ins; 0 del; 2 mod; 896 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 56449 : imported patch 8220310.mut.1
5 lines changed: 5 ins; 0 del; 0 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
59 lines changed: 59 ins; 0 del; 0 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionManager.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
15 lines changed: 6 ins; 7 del; 2 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
4 lines changed: 4 ins; 0 del; 0 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionSet.inline.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
62 lines changed: 62 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
2 lines changed: 0 ins; 0 del; 2 mod; 521 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
1 line changed: 0 ins; 0 del; 1 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/concurrentGCThread.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
0 lines changed: 0 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
0 lines changed: 0 ins; 0 del; 0 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logPrefix.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
1 line changed: 1 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

rev 56448 : imported patch 8220310.mut.0
1 line changed: 1 ins; 0 del; 0 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56452 : [mq]: 8220310.mut.4
25 lines changed: 25 ins; 0 del; 0 mod; 2414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
8 lines changed: 0 ins; 3 del; 5 mod; 4296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
1 line changed: 1 ins; 0 del; 0 mod; 1005 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_freeRegionList.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
0 lines changed: 0 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/sun/hotspot/WhiteBox.java

rev 56448 : imported patch 8220310.mut.0
3 lines changed: 3 ins; 0 del; 0 mod; 555 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1NUMA.cpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
rev 56454 : [mq]: 8220310.mut.6
rev 56455 : [mq]: 8220310.mut.7
223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1NUMA.hpp

rev 56448 : imported patch 8220310.mut.0
rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
rev 56453 : [mq]: 8220310.mut.5
118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java

rev 56449 : imported patch 8220310.mut.1
rev 56450 : imported patch 8220310.mut.2
rev 56451 : imported patch 8220310.mut.3
rev 56452 : [mq]: 8220310.mut.4
245 lines changed: 245 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/sangheki/010_scripts/webrev.ksh (vers 25.18-hg+openjdk.java.net).