Code Review for jdk

Prepared by:serb on Mon Dec 19 22:12:07 MSK 2016
Workspace:/Users/serb/moe/ws/jdk/9/work/jdk
Summary of changes: 237 lines changed: 179 ins; 4 del; 54 mod; 132012 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/event/InputEvent.java

45 lines changed: 29 ins; 0 del; 16 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/event/ActionEvent.java

6 lines changed: 1 ins; 1 del; 4 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/AWTEvent.java

5 lines changed: 5 ins; 0 del; 0 mod; 583 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Event.java

6 lines changed: 3 ins; 1 del; 2 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/event/KeyEvent.java

8 lines changed: 8 ins; 0 del; 0 mod; 1881 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/AWTKeyStroke.java

4 lines changed: 4 ins; 0 del; 0 mod; 788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Component.java

1 line changed: 1 ins; 0 del; 0 mod; 10454 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Container.java

2 lines changed: 2 ins; 0 del; 0 mod; 4978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/KeyboardFocusManager.java

1 line changed: 1 ins; 0 del; 0 mod; 3122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/MenuBar.java

1 line changed: 1 ins; 0 del; 0 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/MenuComponent.java

1 line changed: 1 ins; 0 del; 0 mod; 1087 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/MenuItem.java

1 line changed: 1 ins; 0 del; 0 mod; 962 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/MenuShortcut.java

1 line changed: 1 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/PopupMenu.java

1 line changed: 1 ins; 0 del; 0 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Robot.java

1 line changed: 1 ins; 0 del; 0 mod; 578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Toolkit.java

1 line changed: 1 ins; 0 del; 0 mod; 2336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/dnd/DragSourceDragEvent.java

2 lines changed: 2 ins; 0 del; 0 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/event/MouseEvent.java

6 lines changed: 6 ins; 0 del; 0 mod; 1178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/peer/PopupMenuPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/Autoscroller.java

2 lines changed: 2 ins; 0 del; 0 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/DefaultButtonModel.java

1 line changed: 1 ins; 0 del; 0 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JComboBox.java

1 line changed: 1 ins; 0 del; 0 mod; 2438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JComponent.java

3 lines changed: 3 ins; 0 del; 0 mod; 5632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JFileChooser.java

1 line changed: 1 ins; 0 del; 0 mod; 2057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JList.java

1 line changed: 1 ins; 0 del; 0 mod; 3818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JMenuItem.java

2 lines changed: 2 ins; 0 del; 0 mod; 940 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JPopupMenu.java

1 line changed: 1 ins; 0 del; 0 mod; 1573 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JTable.java

3 lines changed: 2 ins; 0 del; 1 mod; 9747 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JTextField.java

1 line changed: 1 ins; 0 del; 0 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JToggleButton.java

1 line changed: 1 ins; 0 del; 0 mod; 428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JTree.java

4 lines changed: 2 ins; 1 del; 1 mod; 5661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/KeyboardManager.java

1 line changed: 1 ins; 0 del; 0 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/MenuSelectionManager.java

1 line changed: 1 ins; 0 del; 0 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/SwingUtilities.java

1 line changed: 1 ins; 0 del; 0 mod; 2246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/ToolTipManager.java

1 line changed: 1 ins; 0 del; 0 mod; 887 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java

1 line changed: 1 ins; 0 del; 0 mod; 2059 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java

2 lines changed: 2 ins; 0 del; 0 mod; 1403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java

1 line changed: 1 ins; 0 del; 0 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java

1 line changed: 0 ins; 0 del; 1 mod; 1736 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java

2 lines changed: 2 ins; 0 del; 0 mod; 1121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuUI.java

1 line changed: 1 ins; 0 del; 0 mod; 683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java

1 line changed: 1 ins; 0 del; 0 mod; 1259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java

1 line changed: 1 ins; 0 del; 0 mod; 2334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java

1 line changed: 1 ins; 0 del; 0 mod; 2276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java

1 line changed: 0 ins; 0 del; 1 mod; 2748 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java

1 line changed: 1 ins; 0 del; 0 mod; 986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/metal/MetalToolTipUI.java

1 line changed: 1 ins; 0 del; 0 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java

1 line changed: 1 ins; 0 del; 0 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/table/JTableHeader.java

1 line changed: 1 ins; 0 del; 0 mod; 1497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java

3 lines changed: 3 ins; 0 del; 0 mod; 1961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/JTextComponent.java

1 line changed: 1 ins; 0 del; 0 mod; 5113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jconsole/share/classes/sun/tools/jconsole/JConsole.java

4 lines changed: 0 ins; 0 del; 4 mod; 1108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jconsole/share/classes/sun/tools/jconsole/VMPanel.java

3 lines changed: 2 ins; 0 del; 1 mod; 667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/Utils.java

1 line changed: 0 ins; 0 del; 1 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxPopup.java

7 lines changed: 6 ins; 0 del; 1 mod; 387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameDockIconUI.java

2 lines changed: 2 ins; 0 del; 0 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameUI.java

8 lines changed: 6 ins; 0 del; 2 mod; 1029 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java

5 lines changed: 4 ins; 0 del; 1 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java

1 line changed: 1 ins; 0 del; 0 mod; 3818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 1453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/LWListPeer.java

2 lines changed: 2 ins; 0 del; 0 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CMenuItem.java

1 line changed: 0 ins; 0 del; 1 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPopupMenu.java

1 line changed: 1 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java

3 lines changed: 3 ins; 0 del; 0 mod; 949 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifDesktopIconUI.java

2 lines changed: 0 ins; 0 del; 2 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifGraphicsUtils.java

2 lines changed: 1 ins; 0 del; 1 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifInternalFrameTitlePane.java

1 line changed: 0 ins; 0 del; 1 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java

4 lines changed: 1 ins; 1 del; 2 mod; 1278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifPopupMenuUI.java

1 line changed: 1 ins; 0 del; 0 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifTextUI.java

1 line changed: 1 ins; 0 del; 0 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/windows/WindowsTabbedPaneUI.java

1 line changed: 1 ins; 0 del; 0 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/NullComponentPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/SunToolkit.java

2 lines changed: 2 ins; 0 del; 0 mod; 2100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/swing/FilePane.java

1 line changed: 1 ins; 0 del; 0 mod; 2050 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/swing/MenuItemLayoutHelper.java

1 line changed: 1 ins; 0 del; 0 mod; 1323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/swing/SwingUtilities2.java

2 lines changed: 1 ins; 0 del; 1 mod; 2203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/InfoWindow.java

1 line changed: 0 ins; 0 del; 1 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/ListHelper.java

1 line changed: 0 ins; 0 del; 1 mod; 685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java

6 lines changed: 4 ins; 0 del; 2 mod; 1231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XButtonPeer.java

6 lines changed: 4 ins; 0 del; 2 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XChoicePeer.java

1 line changed: 0 ins; 0 del; 1 mod; 1114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XEmbedServerTester.java

4 lines changed: 4 ins; 0 del; 0 mod; 770 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XListPeer.java

4 lines changed: 2 ins; 0 del; 2 mod; 2009 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XMenuBarPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 534 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XPopupMenuPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XScrollPanePeer.java

1 line changed: 1 ins; 0 del; 0 mod; 665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XScrollbar.java

1 line changed: 1 ins; 0 del; 0 mod; 934 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XScrollbarPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XTextAreaPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 1503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XTrayIconPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 657 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11/XWindow.java

1 line changed: 0 ins; 0 del; 1 mod; 1556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WButtonPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WFileDialogPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WPopupMenuPeer.java

3 lines changed: 3 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WPrintDialogPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WTextFieldPeer.java

1 line changed: 1 ins; 0 del; 0 mod; 97 unchg

This code review page was prepared using /Users/serb/moe/tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).