Code Review for langtools

Prepared by: Steven Groeger (groeges) on Thu Jan 31 16:20:57 GMT 2019
Workspace:/home/groeges/source/hotspot8/jdk8u/langtools
Summary of changes: 234 lines changed: 232 ins; 0 del; 2 mod; 4112 unchg
Patch of changes: langtools.patch
Bug id: JDK-8218152] [javac : fails and exits with no error if a bad annotation processor provided
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

7 lines changed: 6 ins; 0 del; 1 mod; 1537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/resources/compiler.properties

4 lines changed: 3 ins; 0 del; 1 mod; 2575 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/BadAnnotationProcessor.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/BadAnnotationProcessor.out

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/InvalidVersionAnnotationProcessor.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/InvalidVersionAnnotationProcessor.out

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/InvalidVersionAnnotationProcessorNoTags.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/InvalidVersionAnnotationProcessorNoTags.out

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/MissingAnnotationProcessor.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/annotations/8218152/MissingAnnotationProcessor.out

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/annotations/8218152/bad.annotation.processor.jar

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/annotations/8218152/invalid.annotation.processor.jar

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/tools/javac/annotations/8218152/missing.annotation.processor.jar

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/groeges/bin/webrev.sh (vers 25.17-hg+openjdk.java.net).