Code Review for jdk

Prepared by:smarks on Wed Dec 15 14:41:19 PST 2010
Workspace:/home/smarks/src/jdk7a/jdk
Compare against: ssh://hg.openjdk.java.net/jdk7/tl-gate/jdk
Compare against version:3185
Summary of changes: 264 lines changed: 0 ins; 0 del; 264 mod; 86183 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/BandStructure.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 2681 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 1217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/util/jar/pack/Package.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 1321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/DeleteOnExitHook.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/File.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 2123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/FileInputStream.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/FileOutputStream.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/FilePermission.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 856 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/ObjectInputStream.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 3505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/ObjectOutputStream.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 2451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/io/ObjectStreamClass.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
13 lines changed: 0 ins; 0 del; 13 mod; 2291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/ApplicationShutdownHooks.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Character.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 6954 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/CharacterName.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Class.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
13 lines changed: 0 ins; 0 del; 13 mod; 3102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/ClassLoader.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
16 lines changed: 0 ins; 0 del; 16 mod; 2192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Package.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 615 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/ProcessBuilder.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 1029 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/String.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 3077 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/StringCoding.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Thread.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 2059 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Throwable.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 940 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/management/ManagementFactory.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 832 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/management/PlatformComponent.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/reflect/Constructor.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 684 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/reflect/Proxy.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/reflect/ReflectAccess.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/sql/DriverManager.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/AbstractList.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
4 lines changed: 0 ins; 0 del; 4 mod; 777 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Arrays.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 3671 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Collections.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
77 lines changed: 0 ins; 0 del; 77 mod; 3840 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/EnumMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/EnumSet.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 439 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Formatter.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 4419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/HashMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 1049 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/HashSet.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
5 lines changed: 0 ins; 0 del; 5 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Hashtable.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
5 lines changed: 0 ins; 0 del; 5 mod; 1098 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/IdentityHashMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 1230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/JumboEnumSet.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/LinkedHashMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/LinkedList.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
4 lines changed: 0 ins; 0 del; 4 mod; 1134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/ListResourceBundle.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/PriorityQueue.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 774 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Properties.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 1114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/RegularEnumSet.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/ServiceLoader.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 535 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/TimSort.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 927 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/TreeMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
7 lines changed: 0 ins; 0 del; 7 mod; 2438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/TreeSet.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
8 lines changed: 0 ins; 0 del; 8 mod; 531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/WeakHashMap.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
4 lines changed: 0 ins; 0 del; 4 mod; 969 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/FileHandler.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/Level.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/LogManager.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
4 lines changed: 0 ins; 0 del; 4 mod; 1194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/LogRecord.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 566 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/Logger.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 1508 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/logging/Logging.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/prefs/AbstractPreferences.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 1612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/regex/Pattern.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 5453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/ZipFile.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 711 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/zip/ZipOutputStream.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/io/Converters.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/util/logging/PlatformLogger.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
3 lines changed: 0 ins; 0 del; 3 mod; 580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/java/lang/ProcessEnvironment.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/java/util/prefs/FileSystemPreferences.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
7 lines changed: 0 ins; 0 del; 7 mod; 999 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/java/lang/ProcessEnvironment.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
2 lines changed: 0 ins; 0 del; 2 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/NPEProvoker/NPEProvoker.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ilib/Inject.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 744 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ilib/InjectBytecodes.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 768 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/TestPlainArrayNotGeneric.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Random/DistinctSeeds.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/logging/ClassLoaderLeakTest.java

rev 3186 : 6880112: Project Coin: Port JDK core library code to use diamond operator
1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

This code review page was prepared using /home/smarks/bin/webrev (vers 23.18-hg).