Code Review for jdk-s1

Prepared by:smarks on Mon Feb 21 17:40:24 PST 2011
Workspace:/home/smarks/src/jdk-s1
Compare against version:qparent
Summary of changes: 207 lines changed: 25 ins; 48 del; 134 mod; 6519 unchg
Patch of changes: jdk-s1.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/lang/Package.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 2 del; 4 mod; 609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/Currency.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
3 lines changed: 2 ins; 0 del; 1 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/util/calendar/LocalGregorianCalendar.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
3 lines changed: 2 ins; 0 del; 1 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/java/util/prefs/FileSystemPreferences.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 0 del; 6 mod; 1000 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Character/CheckScript.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
30 lines changed: 8 ins; 5 del; 17 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Runtime/shutdown/ShutdownHooks.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 2 del; 4 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/BootClassPath/Setup.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
22 lines changed: 4 ins; 2 del; 16 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ilib/Inject.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
19 lines changed: 4 ins; 3 del; 12 mod; 730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigInteger/BigIntegerTest.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
36 lines changed: 0 ins; 23 del; 13 mod; 790 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Currency/ValidateISO4217.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
52 lines changed: 5 ins; 4 del; 43 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Formatter/FailingConstructors.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
3 lines changed: 0 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Locale/LocaleEnhanceTest.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
6 lines changed: 0 ins; 2 del; 4 mod; 1379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/ResourceBundle/Bug6204853.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
12 lines changed: 0 ins; 5 del; 7 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Scanner/FailingConstructors.java

rev 3509 : 7021209: convert lang, math, util to use try-with-resources
Reviewed-by: XXX
3 lines changed: 0 ins; 0 del; 3 mod; 129 unchg

This code review page was prepared using /home/smarks/bin/webrev (vers 23.18-hg).