Code Review for open

Prepared by:stefank on Thu May 30 17:32:42 CEST 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-2
Summary of changes: 539 lines changed: 115 ins; 340 del; 84 mod; 8437 unchg
Patch of changes: open.patch
Bug id: JDK-8081833 : There is a large amount of code near-duplication among the various CommandLineFlagRange_<'type> classes
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

42 lines changed: 11 ins; 8 del; 23 mod; 2370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

13 lines changed: 0 ins; 0 del; 13 mod; 4281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.cpp

247 lines changed: 1 ins; 232 del; 14 mod; 1009 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.hpp

39 lines changed: 10 ins; 25 del; 4 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.inline.hpp

92 lines changed: 85 ins; 0 del; 7 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagConstraintList.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagRangeList.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/writeableFlags.cpp

88 lines changed: 8 ins; 59 del; 21 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/writeableFlags.hpp

16 lines changed: 0 ins; 16 del; 0 mod; 76 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).