Code Review for open

Prepared by:stefank on Thu May 30 17:33:09 CEST 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-5
Summary of changes: 1441 lines changed: 307 ins; 977 del; 157 mod; 14206 unchg
Patch of changes: open.patch
Bug id: JDK-8081833 : There is a large amount of code near-duplication among the various CommandLineFlagRange_<'type> classes
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/periodic/jfrPeriodic.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 638 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

10 lines changed: 1 ins; 0 del; 9 mod; 2700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

42 lines changed: 11 ins; 8 del; 23 mod; 2370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

13 lines changed: 0 ins; 0 del; 13 mod; 4281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.cpp

468 lines changed: 1 ins; 430 del; 37 mod; 986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.hpp

66 lines changed: 13 ins; 48 del; 5 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagConstraintList.cpp

185 lines changed: 0 ins; 165 del; 20 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagConstraintList.hpp

18 lines changed: 0 ins; 15 del; 3 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp

240 lines changed: 0 ins; 230 del; 10 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagRangeList.hpp

9 lines changed: 0 ins; 5 del; 4 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/management.cpp

10 lines changed: 0 ins; 0 del; 10 mod; 2225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/writeableFlags.cpp

88 lines changed: 8 ins; 59 del; 21 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/writeableFlags.hpp

16 lines changed: 0 ins; 16 del; 0 mod; 76 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.inline.hpp

129 lines changed: 129 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/flags/jvmFlagConstraintList.inline.hpp

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/flags/jvmFlagRangeList.inline.hpp

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).