Code Review for open

Prepared by:stefank on Wed May 22 13:54:53 CEST 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-3
Summary of changes: 106 lines changed: 4 ins; 93 del; 9 mod; 6286 unchg
Patch of changes: open.patch
Bug id: JDK-8224599 : Remove globals_ext.hpp
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp

1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/jvmFlagConstraintsG1.hpp

1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.hpp

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/jvmFlagConstraintsGC.hpp

1 line changed: 1 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/allocation.hpp

1 line changed: 1 ins; 0 del; 0 mod; 589 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.cpp

8 lines changed: 0 ins; 2 del; 6 mod; 1505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlag.hpp

5 lines changed: 0 ins; 5 del; 0 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagConstraintList.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/flags/jvmFlagWriteableList.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

4 lines changed: 0 ins; 4 del; 0 mod; 2508 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals_extension.hpp

2 lines changed: 1 ins; 1 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os_ext.hpp

4 lines changed: 0 ins; 4 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/runtime/test_globals.cpp

1 line changed: 1 ins; 0 del; 0 mod; 74 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/runtime/globals_ext.hpp

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).