Code Review for open

Prepared by:stefank on Thu Nov 21 11:18:00 CET 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-2
Summary of changes: 858 lines changed: 288 ins; 304 del; 266 mod; 69574 unchg
Patch of changes: open.patch
Bug id: JDK-8234562 : Move orderAccess::release_store*/load_acquire to Atomic
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/nativeInst_ppc.cpp

1 line changed: 0 ins; 0 del; 1 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 3807 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 5697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp

12 lines changed: 12 ins; 0 del; 0 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp

9 lines changed: 0 ins; 9 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp

50 lines changed: 50 ins; 0 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp

50 lines changed: 0 ins; 50 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp

25 lines changed: 21 ins; 4 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp

25 lines changed: 4 ins; 21 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp

13 lines changed: 13 ins; 0 del; 0 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp

10 lines changed: 0 ins; 10 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp

7 lines changed: 7 ins; 0 del; 0 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp

7 lines changed: 0 ins; 7 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp

50 lines changed: 50 ins; 0 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp

50 lines changed: 0 ins; 50 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp

52 lines changed: 52 ins; 0 del; 0 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp

52 lines changed: 0 ins; 52 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

15 lines changed: 0 ins; 0 del; 15 mod; 961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.cpp

1 line changed: 0 ins; 0 del; 1 mod; 720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/dependencyContext.cpp

1 line changed: 0 ins; 0 del; 1 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CodeCacheRemSet.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionRemSet.cpp

1 line changed: 0 ins; 0 del; 1 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionRemSet.hpp

1 line changed: 0 ins; 0 del; 1 mod; 464 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/concurrentGCThread.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

13 lines changed: 0 ins; 0 del; 13 mod; 1044 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/ptrQueue.cpp

1 line changed: 0 ins; 0 del; 1 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 3003 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 698 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp

11 lines changed: 0 ins; 0 del; 11 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1019 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zLiveMap.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zLiveMap.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodData.cpp

1 line changed: 0 ins; 0 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zObjectAllocator.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/oopMapCache.cpp

1 line changed: 0 ins; 0 del; 1 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/utilities/jfrHashtable.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logDecorations.cpp

1 line changed: 0 ins; 0 del; 1 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/accessBackend.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/array.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 2469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.inline.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 4058 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 963 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1873 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.inline.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 4261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3644 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnvBase.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRawMonitor.cpp

1 line changed: 0 ins; 0 del; 1 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/atomic.hpp

79 lines changed: 79 ins; 0 del; 0 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/handshake.cpp

1 line changed: 0 ins; 0 del; 1 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/init.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/interfaceSupport.cpp

1 line changed: 0 ins; 0 del; 1 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 2005 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/orderAccess.hpp

98 lines changed: 0 ins; 96 del; 2 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/perfMemory.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/safepoint.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 1296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 2179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 5066 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.inline.hpp

11 lines changed: 0 ins; 0 del; 11 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/threadHeapSampler.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/threadSMR.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/threadSMR.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmThread.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/concurrentHashTable.inline.hpp

13 lines changed: 0 ins; 0 del; 13 mod; 1250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalCounter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalCounter.inline.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/hashtable.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/singleWriterSynchronizer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_globalCounter.cpp

7 lines changed: 0 ins; 1 del; 6 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_globalCounter_nested.cpp

7 lines changed: 0 ins; 1 del; 6 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_lockFreeStack.cpp

4 lines changed: 0 ins; 1 del; 3 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_singleWriterSynchronizer.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_waitBarrier.cpp

8 lines changed: 0 ins; 0 del; 8 mod; 144 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).