--- old/src/hotspot/share/oops/accessBackend.inline.hpp 2019-11-21 11:54:18.464078064 +0100 +++ new/src/hotspot/share/oops/accessBackend.inline.hpp 2019-11-21 11:54:18.212073802 +0100 @@ -103,17 +103,17 @@ template template -inline T RawAccessBarrier::oop_atomic_xchg(T new_value, void* addr) { +inline T RawAccessBarrier::oop_atomic_xchg(void* addr, T new_value) { typedef typename AccessInternal::EncodedType::type Encoded; Encoded encoded_new = encode(new_value); - Encoded encoded_result = atomic_xchg(encoded_new, reinterpret_cast(addr)); + Encoded encoded_result = atomic_xchg(reinterpret_cast(addr), encoded_new); return decode(encoded_result); } template template -inline T RawAccessBarrier::oop_atomic_xchg_at(T new_value, oop base, ptrdiff_t offset) { - return oop_atomic_xchg(new_value, field_addr(base, offset)); +inline T RawAccessBarrier::oop_atomic_xchg_at(oop base, ptrdiff_t offset, T new_value) { + return oop_atomic_xchg(field_addr(base, offset), new_value); } template @@ -203,9 +203,9 @@ template inline typename EnableIf< HasDecorator::value, T>::type -RawAccessBarrier::atomic_xchg_internal(T new_value, void* addr) { - return Atomic::xchg(new_value, - reinterpret_cast(addr)); +RawAccessBarrier::atomic_xchg_internal(void* addr, T new_value) { + return Atomic::xchg(reinterpret_cast(addr), + new_value); } // For platforms that do not have native support for wide atomics, @@ -216,9 +216,9 @@ template inline typename EnableIf< AccessInternal::PossiblyLockedAccess::value, T>::type -RawAccessBarrier::atomic_xchg_maybe_locked(T new_value, void* addr) { +RawAccessBarrier::atomic_xchg_maybe_locked(void* addr, T new_value) { if (!AccessInternal::wide_atomic_needs_locking()) { - return atomic_xchg_internal(new_value, addr); + return atomic_xchg_internal(addr, new_value); } else { AccessInternal::AccessLocker access_lock; volatile T* p = reinterpret_cast(addr);