Code Review for open

Prepared by:stefank on Tue Apr 28 15:47:14 CEST 2020
Workspace:/Users/stefan/hg/jdk/jdk/open
Compare against version:-3
Summary of changes: 432 lines changed: 106 ins; 96 del; 230 mod; 16156 unchg
Patch of changes: open.patch
Bug id: JDK-8244010 : Simplify usages of ProcessTools.createJavaProcessBuilder in our tests
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java

1 line changed: 0 ins; 0 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java

1 line changed: 0 ins; 0 del; 1 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/bmi/BMITestRunner.java

2 lines changed: 0 ins; 1 del; 1 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jsr292/ContinuousCallSiteTargetChange.java

2 lines changed: 0 ins; 1 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetFlagValueTest.java

5 lines changed: 3 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/linkage/TestLinkageErrorInGenerateOopMap.java

10 lines changed: 1 ins; 0 del; 9 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java

33 lines changed: 1 ins; 1 del; 31 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestAgeOutput.java

5 lines changed: 0 ins; 3 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestAllocateHeapAt.java

6 lines changed: 0 ins; 2 del; 4 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestAllocateHeapAtError.java

5 lines changed: 1 ins; 2 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestAllocateHeapAtMultiple.java

2 lines changed: 0 ins; 1 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestCardTablePageCommits.java

5 lines changed: 3 ins; 0 del; 2 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestNumWorkerOutput.java

5 lines changed: 0 ins; 3 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestSmallHeap.java

7 lines changed: 0 ins; 2 del; 5 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestVerifyDuringStartup.java

5 lines changed: 1 ins; 2 del; 2 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestVerifySilently.java

2 lines changed: 0 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestVerifySubSet.java

2 lines changed: 0 ins; 1 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/GCArguments.java

12 lines changed: 11 ins; 1 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestG1ConcMarkStepDurationMillis.java

1 line changed: 0 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestG1ConcRefinementThreads.java

1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestG1HeapRegionSize.java

1 line changed: 0 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestG1PercentageOptions.java

2 lines changed: 0 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestMaxHeapSizeTools.java

0 lines changed: 0 ins; 0 del; 0 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestMaxMinHeapFreeRatioFlags.java

2 lines changed: 0 ins; 0 del; 2 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestMaxNewSize.java

2 lines changed: 0 ins; 0 del; 2 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestMaxRAMFlags.java

2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestMinAndInitialSurvivorRatioFlags.java

1 line changed: 0 ins; 0 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestNewRatioFlag.java

1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestNewSizeFlags.java

1 line changed: 0 ins; 0 del; 1 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestObjectTenuringFlags.java

1 line changed: 0 ins; 0 del; 1 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java

17 lines changed: 9 ins; 1 del; 7 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestParallelRefProc.java

1 line changed: 0 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestSelectDefaultGC.java

12 lines changed: 4 ins; 7 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java

9 lines changed: 0 ins; 1 del; 8 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestSoftMaxHeapSizeFlag.java

14 lines changed: 0 ins; 0 del; 14 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestSurvivorRatioFlag.java

1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestTargetSurvivorRatioFlag.java

2 lines changed: 0 ins; 0 del; 2 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestUseCompressedOopsErgoTools.java

1 line changed: 0 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestUseNUMAInterleaving.java

5 lines changed: 1 ins; 2 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java

4 lines changed: 0 ins; 2 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/ergonomics/TestInitialGCThreadLogging.java

10 lines changed: 6 ins; 3 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/Test2GbHeap.java

1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java

5 lines changed: 0 ins; 3 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestHumongousCodeCacheRoots.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestMarkStackSizes.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestPLABSizeBounds.java

1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestPrintRegionRememberedSetInfo.java

2 lines changed: 0 ins; 1 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestRemsetLoggingTools.java

2 lines changed: 0 ins; 1 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestSharedArchiveWithPreTouch.java

1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData.java

4 lines changed: 0 ins; 3 del; 1 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestStringDeduplicationTools.java

1 line changed: 0 ins; 0 del; 1 mod; 445 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/TestVerifyGCType.java

2 lines changed: 0 ins; 1 del; 1 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/ihop/TestIHOPErgo.java

2 lines changed: 0 ins; 1 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java

1 line changed: 0 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/logging/TestG1LoggingFailure.java

1 line changed: 0 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/mixedgc/TestLogging.java

1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/plab/TestPLABEvacuationFailure.java

1 line changed: 0 ins; 0 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/plab/TestPLABPromotion.java

1 line changed: 0 ins; 0 del; 1 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/plab/TestPLABResize.java

1 line changed: 0 ins; 0 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/metaspace/TestSizeTransitions.java

1 line changed: 0 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java

2 lines changed: 0 ins; 1 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java

2 lines changed: 0 ins; 1 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java

2 lines changed: 0 ins; 1 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java

2 lines changed: 0 ins; 1 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java

2 lines changed: 0 ins; 1 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java

2 lines changed: 0 ins; 1 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java

3 lines changed: 0 ins; 1 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/TestStressG1Humongous.java

1 line changed: 0 ins; 0 del; 1 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/gclocker/TestExcessGCLockerCollections.java

1 line changed: 0 ins; 0 del; 1 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/z/TestAllocateHeapAt.java

2 lines changed: 0 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/z/TestHighUsage.java

8 lines changed: 0 ins; 0 del; 8 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/z/TestSmallHeap.java

2 lines changed: 0 ins; 0 del; 2 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOption.java

1 line changed: 0 ins; 0 del; 1 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java

1 line changed: 0 ins; 0 del; 1 mod; 559 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java

24 lines changed: 15 ins; 0 del; 9 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/TestHexArguments.java

5 lines changed: 0 ins; 1 del; 4 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/VMOptionsFile/TestVMOptionsFile.java

1 line changed: 0 ins; 0 del; 1 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java

1 line changed: 0 ins; 0 del; 1 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Shutdown/ShutdownTest.java

15 lines changed: 2 ins; 10 del; 3 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java

4 lines changed: 0 ins; 2 del; 2 mod; 682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java

1 line changed: 0 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/logging/LoaderConstraintsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/memory/LargePages/TestLargePagesFlags.java

1 line changed: 0 ins; 0 del; 1 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/records/RedefineRecord.java

6 lines changed: 2 ins; 0 del; 4 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/dcmd/gc/RunFinalizationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java

5 lines changed: 1 ins; 0 del; 4 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineWithUnresolvedClass.java

3 lines changed: 0 ins; 1 del; 2 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/logging/TestLogRotation.java

11 lines changed: 0 ins; 1 del; 10 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestCpoolForInvokeDynamic.java

7 lines changed: 0 ins; 4 del; 3 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestDefaultMethods.java

7 lines changed: 0 ins; 4 del; 3 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestG1HeapRegion.java

7 lines changed: 1 ins; 4 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSize.java

6 lines changed: 0 ins; 4 del; 2 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java

8 lines changed: 0 ins; 5 del; 3 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/serviceability/sa/TestRevPtrsForInvokeDynamic.java

7 lines changed: 1 ins; 4 del; 2 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/vmTestbase/gc/huge/quicklook/largeheap/MemOptions/MemOptionsTest.java

4 lines changed: 0 ins; 2 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/process/ProcessTools.java

44 lines changed: 43 ins; 0 del; 1 mod; 644 unchg

This code review page was prepared using /Users/stefan/hg/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).