Code Review for open

Prepared by:stefank on Tue Jun 30 18:05:52 CEST 2020
Workspace:/Users/stefan/hg/jdk/jdk/open
Compare against version:-5
Summary of changes: 772 lines changed: 285 ins; 316 del; 171 mod; 21819 unchg
Patch of changes: open.patch
Bug id: JDK-8248391 : Unify handling of all OopStorage instances in weak root processing
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 968 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/dictionary.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/protectionDomainCache.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

19 lines changed: 6 ins; 8 del; 5 mod; 794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.hpp

21 lines changed: 8 ins; 13 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 3046 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 2145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.cpp

9 lines changed: 8 ins; 0 del; 1 mod; 1532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.hpp

4 lines changed: 2 ins; 0 del; 2 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

19 lines changed: 17 ins; 0 del; 2 mod; 1062 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.hpp

13 lines changed: 13 ins; 0 del; 0 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageParState.hpp

10 lines changed: 10 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageParState.inline.hpp

4 lines changed: 4 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSet.cpp

31 lines changed: 13 ins; 1 del; 17 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSet.hpp

39 lines changed: 9 ins; 23 del; 7 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSetParState.hpp

16 lines changed: 16 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSetParState.inline.hpp

61 lines changed: 59 ins; 0 del; 2 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessor.cpp

23 lines changed: 1 ins; 18 del; 4 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessor.inline.hpp

4 lines changed: 0 ins; 2 del; 2 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahClosures.hpp

12 lines changed: 12 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp

29 lines changed: 29 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

45 lines changed: 2 ins; 35 del; 8 mod; 3126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp

9 lines changed: 2 ins; 6 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp

66 lines changed: 0 ins; 50 del; 16 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp

62 lines changed: 0 ins; 44 del; 18 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRootsIterator.cpp

68 lines changed: 0 ins; 59 del; 9 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRootsIterator.hpp

21 lines changed: 3 ins; 10 del; 8 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zWeakRootsProcessor.cpp

4 lines changed: 4 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp

1 line changed: 0 ins; 0 del; 1 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmci.cpp

1 line changed: 0 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

21 lines changed: 21 ins; 0 del; 0 mod; 1223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.hpp

9 lines changed: 8 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiImpl.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 1013 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.cpp

20 lines changed: 4 ins; 8 del; 8 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.hpp

10 lines changed: 3 ins; 5 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/init.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/jniHandles.cpp

10 lines changed: 3 ins; 1 del; 6 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/jniHandles.hpp

5 lines changed: 5 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_oopStorageSet.cpp

86 lines changed: 23 ins; 33 del; 30 mod; 42 unchg

This code review page was prepared using /Users/stefan/hg/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).