Code Review for open

Prepared by:stefank on Tue Jun 30 18:04:12 CEST 2020
Workspace:/Users/stefan/hg/jdk/jdk/open
Compare against version:-3
Summary of changes: 277 lines changed: 115 ins; 67 del; 95 mod; 16335 unchg
Patch of changes: open.patch
Bug id: JDK-8248391 : Unify handling of all OopStorage instances in weak root processing
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 968 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/dictionary.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/protectionDomainCache.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

5 lines changed: 3 ins; 0 del; 2 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.hpp

14 lines changed: 8 ins; 6 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 3046 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 2145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.cpp

9 lines changed: 8 ins; 0 del; 1 mod; 1532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.hpp

4 lines changed: 2 ins; 0 del; 2 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

8 lines changed: 5 ins; 1 del; 2 mod; 1074 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSet.cpp

33 lines changed: 12 ins; 3 del; 18 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSet.hpp

39 lines changed: 9 ins; 23 del; 7 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp

1 line changed: 0 ins; 0 del; 1 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmci.cpp

1 line changed: 0 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

21 lines changed: 21 ins; 0 del; 0 mod; 1223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.hpp

9 lines changed: 8 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiImpl.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 1013 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.cpp

5 lines changed: 3 ins; 0 del; 2 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.hpp

4 lines changed: 3 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/init.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/jniHandles.cpp

10 lines changed: 3 ins; 1 del; 6 mod; 660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/jniHandles.hpp

5 lines changed: 5 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_oopStorageSet.cpp

86 lines changed: 23 ins; 33 del; 30 mod; 42 unchg

This code review page was prepared using /Users/stefan/hg/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).