Code Review for source

Prepared by:stuefe stuefe on Wed Aug 12 19:07:04 CEST 2020
Workspace:/shared/projects/openjdk/jdk-jdk/source
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:60537
Summary of changes: 13483 lines changed: 8129 ins; 4395 del; 959 mod; 1848 unchg
Changeset: source.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace.cpp

rev 60538 : imported patch jep387-core.patch
1174 lines changed: 210 ins; 894 del; 70 mod; 642 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace.hpp

rev 60538 : imported patch jep387-core.patch
381 lines changed: 92 ins; 229 del; 60 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/chunkManager.cpp

rev 60538 : imported patch jep387-core.patch
698 lines changed: 180 ins; 343 del; 175 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/chunkManager.hpp

rev 60538 : imported patch jep387-core.patch
303 lines changed: 145 ins; 151 del; 7 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metachunk.cpp

rev 60538 : imported patch jep387-core.patch
509 lines changed: 395 ins; 60 del; 54 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metachunk.hpp

rev 60538 : imported patch jep387-core.patch
313 lines changed: 186 ins; 38 del; 89 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 60538 : imported patch jep387-core.patch
145 lines changed: 57 ins; 66 del; 22 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 60538 : imported patch jep387-core.patch
155 lines changed: 72 ins; 71 del; 12 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp

rev 60538 : imported patch jep387-core.patch
185 lines changed: 47 ins; 66 del; 72 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp

rev 60538 : imported patch jep387-core.patch
137 lines changed: 29 ins; 50 del; 58 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

rev 60538 : imported patch jep387-core.patch
413 lines changed: 63 ins; 236 del; 114 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/virtualSpaceList.hpp

rev 60538 : imported patch jep387-core.patch
133 lines changed: 34 ins; 48 del; 51 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp

rev 60538 : imported patch jep387-core.patch
728 lines changed: 256 ins; 324 del; 148 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp

rev 60538 : imported patch jep387-core.patch
317 lines changed: 210 ins; 80 del; 27 mod; 56 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/allocationGuard.hpp

rev 60538 : imported patch jep387-core.patch
120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/arenaGrowthPolicy.cpp

rev 60538 : imported patch jep387-core.patch
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/arenaGrowthPolicy.hpp

rev 60538 : imported patch jep387-core.patch
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/binlist.hpp

rev 60538 : imported patch jep387-core.patch
224 lines changed: 224 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/blocktree.cpp

rev 60538 : imported patch jep387-core.patch
169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/blocktree.hpp

rev 60538 : imported patch jep387-core.patch
448 lines changed: 448 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/chunkHeaderPool.cpp

rev 60538 : imported patch jep387-core.patch
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/chunkHeaderPool.hpp

rev 60538 : imported patch jep387-core.patch
149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/chunkLevel.cpp

rev 60538 : imported patch jep387-core.patch
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/chunkLevel.hpp

rev 60538 : imported patch jep387-core.patch
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.cpp

rev 60538 : imported patch jep387-core.patch
210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/commitLimiter.cpp

rev 60538 : imported patch jep387-core.patch
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/commitLimiter.hpp

rev 60538 : imported patch jep387-core.patch
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/commitMask.cpp

rev 60538 : imported patch jep387-core.patch
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/commitMask.hpp

rev 60538 : imported patch jep387-core.patch
182 lines changed: 182 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/counter.hpp

rev 60538 : imported patch jep387-core.patch
186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/freeBlocks.cpp

rev 60538 : imported patch jep387-core.patch
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/freeBlocks.hpp

rev 60538 : imported patch jep387-core.patch
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/freeChunkList.cpp

rev 60538 : imported patch jep387-core.patch
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/freeChunkList.hpp

rev 60538 : imported patch jep387-core.patch
275 lines changed: 275 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/internStat.cpp

rev 60538 : imported patch jep387-core.patch
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/internStat.hpp

rev 60538 : imported patch jep387-core.patch
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metachunkList.cpp

rev 60538 : imported patch jep387-core.patch
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metachunkList.hpp

rev 60538 : imported patch jep387-core.patch
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceArena.cpp

rev 60538 : imported patch jep387-core.patch
556 lines changed: 556 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceArena.hpp

rev 60538 : imported patch jep387-core.patch
164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceContext.cpp

rev 60538 : imported patch jep387-core.patch
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceContext.hpp

rev 60538 : imported patch jep387-core.patch
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceEnums.cpp

rev 60538 : imported patch jep387-core.patch
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceEnums.hpp

rev 60538 : imported patch jep387-core.patch
67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceReport.cpp

rev 60538 : imported patch jep387-core.patch
379 lines changed: 379 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/metaspaceReport.hpp

rev 60538 : imported patch jep387-core.patch
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/rootChunkArea.cpp

rev 60538 : imported patch jep387-core.patch
565 lines changed: 565 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/rootChunkArea.hpp

rev 60538 : imported patch jep387-core.patch
211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/runningCounters.cpp

rev 60538 : imported patch jep387-core.patch
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/runningCounters.hpp

rev 60538 : imported patch jep387-core.patch
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/settings.cpp

rev 60538 : imported patch jep387-core.patch
140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/memory/metaspace/settings.hpp

rev 60538 : imported patch jep387-core.patch
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/blockFreelist.cpp

rev 60538 : imported patch jep387-core.patch
109 lines changed: 0 ins; 109 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/blockFreelist.hpp

rev 60538 : imported patch jep387-core.patch
92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/metaDebug.cpp

rev 60538 : imported patch jep387-core.patch
63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/metaDebug.hpp

rev 60538 : imported patch jep387-core.patch
57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/metabase.hpp

rev 60538 : imported patch jep387-core.patch
80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/metablock.hpp

rev 60538 : imported patch jep387-core.patch
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/occupancyMap.cpp

rev 60538 : imported patch jep387-core.patch
135 lines changed: 0 ins; 135 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/occupancyMap.hpp

rev 60538 : imported patch jep387-core.patch
242 lines changed: 0 ins; 242 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/smallBlocks.cpp

rev 60538 : imported patch jep387-core.patch
62 lines changed: 0 ins; 62 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/smallBlocks.hpp

rev 60538 : imported patch jep387-core.patch
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/spaceManager.cpp

rev 60538 : imported patch jep387-core.patch
528 lines changed: 0 ins; 528 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/memory/metaspace/spaceManager.hpp

rev 60538 : imported patch jep387-core.patch
233 lines changed: 0 ins; 233 del; 0 mod; 0 unchg

This code review page was prepared using /shared/projects/openjdk/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).