Code Review for source

Prepared by:stuefe stuefe on Tue Apr 24 07:16:48 CEST 2018
Workspace:/shared/projects/openjdk/jdk-jdk/source
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:49869
Summary of changes: 2266 lines changed: 1416 ins; 570 del; 280 mod; 13132 unchg
Patch of changes: source.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metachunk.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
4 lines changed: 3 ins; 0 del; 1 mod; 246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 49869 : imported patch 8202074-metaspace-retire-after-humongous-chunks-are-allocated
rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
1146 lines changed: 405 ins; 497 del; 244 mod; 4602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
137 lines changed: 71 ins; 49 del; 17 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vm_operations.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vm_operations.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
7 lines changed: 4 ins; 0 del; 3 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/diagnosticCommand.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
2 lines changed: 1 ins; 0 del; 1 mod; 1050 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/diagnosticCommand.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
21 lines changed: 0 ins; 21 del; 0 mod; 869 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memReporter.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memTracker.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
3 lines changed: 1 ins; 0 del; 2 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/nmtCommon.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
8 lines changed: 2 ins; 2 del; 4 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/virtualMemoryTracker.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 527 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/ostream.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
86 lines changed: 86 ins; 0 del; 0 mod; 1073 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/ostream.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
13 lines changed: 12 ins; 1 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/vmError.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
14 lines changed: 14 ins; 0 del; 0 mod; 1721 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/TEST.ROOT

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/NMT/PrintNMTStatistics.java

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
4 lines changed: 4 ins; 0 del; 0 mod; 66 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp (was src/hotspot/share/services/metaspaceDCmd.cpp)

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
68 lines changed: 64 ins; 0 del; 4 mod; 32 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceDCmd.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
278 lines changed: 278 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Metaspace/PrintMetaspaceDcmd.java

rev 49870 : 8201572: Improve Metaspace reporting
Reviewed-by:
126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).