--- old/src/jdk.jextract/share/classes/com/sun/tools/jextract/JType.java 2019-04-25 22:06:10.000000000 +0530 +++ new/src/jdk.jextract/share/classes/com/sun/tools/jextract/JType.java 2019-04-25 22:06:09.000000000 +0530 @@ -22,16 +22,10 @@ */ package com.sun.tools.jextract; -import jdk.internal.org.objectweb.asm.ClassVisitor; import java.foreign.memory.Callback; import java.foreign.memory.Pointer; import java.util.Objects; -import static jdk.internal.org.objectweb.asm.Opcodes.ACC_ABSTRACT; -import static jdk.internal.org.objectweb.asm.Opcodes.ACC_INTERFACE; -import static jdk.internal.org.objectweb.asm.Opcodes.ACC_PUBLIC; -import static jdk.internal.org.objectweb.asm.Opcodes.ACC_STATIC; - /** * A Java Type descriptor */ @@ -44,10 +38,6 @@ */ public abstract String getDescriptor(); - public void visitInner(ClassVisitor cv) {} - - public String getSignature(boolean isArgument) { return getDescriptor(); } - public abstract String getSourceSignature(boolean isArgument); public final static JType Void = new PrimitiveType("V", of(Void.class), "void"); @@ -183,14 +173,6 @@ return clsName; } } - - @Override - public void visitInner(ClassVisitor cv) { - if (enclosingName != null) { - cv.visitInnerClass(clsName, enclosingName, simpleName, - ACC_PUBLIC | ACC_STATIC | ACC_ABSTRACT | ACC_INTERFACE); - } - } } public final static class ArrayType extends JType { @@ -206,23 +188,6 @@ } @Override - public void visitInner(ClassVisitor cv) { - elementType.visitInner(cv); - } - - @Override - public String getSignature(boolean isArgument) { - StringBuilder sb = new StringBuilder(); - sb.append("L"); - sb.append(java.foreign.memory.Array.class.getName().replace('.', '/')); - sb.append("<"); - JType pt = elementType; - sb.append(pt.box().getSignature(isArgument)); - sb.append(">;"); - return sb.toString(); - } - - @Override public String getSourceSignature(boolean isArgument) { StringBuilder sb = new StringBuilder(); sb.append("Array"); // java.foreign.memory.* will be imported @@ -281,30 +246,6 @@ throw new UnsupportedOperationException(); } - @Override - public void visitInner(ClassVisitor cv) { - returnType.visitInner(cv); - for (JType at : args) { - at.visitInner(cv); - } - } - - @Override - public String getSignature(boolean isArgument) { - StringBuilder sb = new StringBuilder(); - sb.append('('); - // ensure sequence - for (int i = 0; i < args.length; i++) { - sb.append(args[i].getSignature(true)); - } - if (isVarArgs) { - sb.append("[Ljava/lang/Object;"); - } - sb.append(')'); - sb.append(returnType.getSignature(false)); - return sb.toString(); - } - public String getNativeDescriptor() { return layout.toString(); } @@ -321,12 +262,6 @@ Function getFunction() { return fn; } - - @Override - public void visitInner(ClassVisitor cv) { - fn.visitInner(cv); - super.visitInner(cv); - } } public static class GenericType extends ClassType { @@ -342,24 +277,6 @@ } @Override - public String getSignature(boolean isArgument) { - StringBuilder sb = new StringBuilder(); - sb.append("L"); - sb.append(clsName); - sb.append("<"); - if (targ == JType.Void && isArgument) { - sb.append("*"); - } else { - if (targ instanceof GenericType && isArgument) { - sb.append("+"); - } - sb.append(targ.box().getSignature(isArgument)); - } - sb.append(">;"); - return sb.toString(); - } - - @Override public String getSourceSignature(boolean isArgument) { StringBuilder sb = new StringBuilder(); sb.append(super.getSourceSignature(isArgument)); @@ -383,11 +300,5 @@ public static GenericType ofCallback(JType targ) { return new GenericType(JType.binaryName(Callback.class), targ); } - - @Override - public void visitInner(ClassVisitor cv) { - targ.visitInner(cv); - super.visitInner(cv); - } } }