Code Review for hs8006088

Prepared by:tschatzl on Tue Apr 30 17:10:08 CEST 2013
Workspace:/home/thomas/Downloads/shared/8006088/hs8006088
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:4559
Summary of changes: 612 lines changed: 577 ins; 18 del; 17 mod; 8734 unchg
Patch of changes: hs8006088.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/collectorPolicy.cpp

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
43 lines changed: 25 ins; 15 del; 3 mod; 849 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/whitebox.cpp

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
10 lines changed: 10 ins; 0 del; 0 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
28 lines changed: 12 ins; 3 del; 13 mod; 3582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
1 line changed: 0 ins; 0 del; 1 mod; 3740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
3 lines changed: 3 ins; 0 del; 0 mod; 116 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestCMSHeapSizeFlags.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestG1HeapSizeFlags.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestMaxHeapSizeTools.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
295 lines changed: 295 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestMinInitialErgonomics.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestParallelHeapSizeFlags.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/arguments/TestSerialHeapSizeFlags.java

rev 4560 : 8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev.sh (vers 23.18-hg).