src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp

Print this page
rev 6327 : 8019342: G1: High "Other" time most likely due to card redirtying
Summary: Parallelize card redirtying to decrease the time it takes.
Reviewed-by: brutisso


  53   if (cl == NULL) return true;
  54   for (size_t i = index; i < sz; i += oopSize) {
  55     int ind = byte_index_to_index((int)i);
  56     jbyte* card_ptr = (jbyte*)buf[ind];
  57     if (card_ptr != NULL) {
  58       // Set the entry to null, so we don't do it again (via the test
  59       // above) if we reconsider this buffer.
  60       if (consume) buf[ind] = NULL;
  61       if (!cl->do_card_ptr(card_ptr, worker_i)) return false;
  62     }
  63   }
  64   return true;
  65 }
  66 
  67 #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away
  68 #pragma warning( disable:4355 ) // 'this' : used in base member initializer list
  69 #endif // _MSC_VER
  70 
  71 DirtyCardQueueSet::DirtyCardQueueSet(bool notify_when_complete) :
  72   PtrQueueSet(notify_when_complete),
  73   _closure(NULL),
  74   _shared_dirty_card_queue(this, true /*perm*/),
  75   _free_ids(NULL),
  76   _processed_buffers_mut(0), _processed_buffers_rs_thread(0)
  77 {
  78   _all_active = true;
  79 }
  80 
  81 // Determines how many mutator threads can process the buffers in parallel.
  82 uint DirtyCardQueueSet::num_par_ids() {
  83   return (uint)os::processor_count();
  84 }
  85 
  86 void DirtyCardQueueSet::initialize(Monitor* cbl_mon, Mutex* fl_lock,
  87                                    int process_completed_threshold,
  88                                    int max_completed_queue,
  89                                    Mutex* lock, PtrQueueSet* fl_owner) {

  90   PtrQueueSet::initialize(cbl_mon, fl_lock, process_completed_threshold,
  91                           max_completed_queue, fl_owner);
  92   set_buffer_size(G1UpdateBufferSize);
  93   _shared_dirty_card_queue.set_lock(lock);
  94   _free_ids = new FreeIdSet((int) num_par_ids(), _cbl_mon);
  95 }
  96 
  97 void DirtyCardQueueSet::handle_zero_index_for_thread(JavaThread* t) {
  98   t->dirty_card_queue().handle_zero_index();
  99 }
 100 
 101 void DirtyCardQueueSet::set_closure(CardTableEntryClosure* closure) {
 102   _closure = closure;
 103 }
 104 
 105 void DirtyCardQueueSet::iterate_closure_all_threads(bool consume,
 106                                                     uint worker_i) {
 107   assert(SafepointSynchronize::is_at_safepoint(), "Must be at safepoint.");
 108   for(JavaThread* t = Threads::first(); t; t = t->next()) {
 109     bool b = t->dirty_card_queue().apply_closure(_closure, consume);
 110     guarantee(b, "Should not be interrupted.");
 111   }
 112   bool b = shared_dirty_card_queue()->apply_closure(_closure,
 113                                                     consume,
 114                                                     worker_i);
 115   guarantee(b, "Should not be interrupted.");
 116 }
 117 
 118 bool DirtyCardQueueSet::mut_process_buffer(void** buf) {
 119 
 120   // Used to determine if we had already claimed a par_id
 121   // before entering this method.
 122   bool already_claimed = false;
 123 
 124   // We grab the current JavaThread.
 125   JavaThread* thread = JavaThread::current();
 126 
 127   // We get the the number of any par_id that this thread
 128   // might have already claimed.
 129   uint worker_i = thread->get_claimed_par_id();
 130 
 131   // If worker_i is not UINT_MAX then the thread has already claimed
 132   // a par_id. We make note of it using the already_claimed value
 133   if (worker_i != UINT_MAX) {
 134     already_claimed = true;
 135   } else {
 136 
 137     // Otherwise we need to claim a par id
 138     worker_i = _free_ids->claim_par_id();
 139 
 140     // And store the par_id value in the thread
 141     thread->set_claimed_par_id(worker_i);
 142   }
 143 
 144   bool b = false;
 145   if (worker_i != UINT_MAX) {
 146     b = DirtyCardQueue::apply_closure_to_buffer(_closure, buf, 0,
 147                                                 _sz, true, worker_i);
 148     if (b) Atomic::inc(&_processed_buffers_mut);
 149 
 150     // If we had not claimed an id before entering the method
 151     // then we must release the id.
 152     if (!already_claimed) {
 153 
 154       // we release the id
 155       _free_ids->release_par_id(worker_i);
 156 
 157       // and set the claimed_id in the thread to UINT_MAX
 158       thread->set_claimed_par_id(UINT_MAX);
 159     }
 160   }
 161   return b;
 162 }
 163 
 164 
 165 BufferNode*
 166 DirtyCardQueueSet::get_completed_buffer(int stop_at) {


 201     } else {
 202       enqueue_complete_buffer(buf, index);
 203       return false;
 204     }
 205   } else {
 206     return false;
 207   }
 208 }
 209 
 210 bool DirtyCardQueueSet::apply_closure_to_completed_buffer(CardTableEntryClosure* cl,
 211                                                           uint worker_i,
 212                                                           int stop_at,
 213                                                           bool during_pause) {
 214   assert(!during_pause || stop_at == 0, "Should not leave any completed buffers during a pause");
 215   BufferNode* nd = get_completed_buffer(stop_at);
 216   bool res = apply_closure_to_completed_buffer_helper(cl, worker_i, nd);
 217   if (res) Atomic::inc(&_processed_buffers_rs_thread);
 218   return res;
 219 }
 220 
 221 bool DirtyCardQueueSet::apply_closure_to_completed_buffer(uint worker_i,
 222                                                           int stop_at,
 223                                                           bool during_pause) {
 224   return apply_closure_to_completed_buffer(_closure, worker_i,
 225                                            stop_at, during_pause);
 226 }
 227 
 228 void DirtyCardQueueSet::apply_closure_to_all_completed_buffers() {
 229   BufferNode* nd = _completed_buffers_head;
 230   while (nd != NULL) {
 231     bool b =
 232       DirtyCardQueue::apply_closure_to_buffer(_closure,
 233                                               BufferNode::make_buffer_from_node(nd),
 234                                               0, _sz, false);
 235     guarantee(b, "Should not stop early.");
 236     nd = nd->next();
 237   }
 238 }
 239 


















 240 // Deallocates any completed log buffers
 241 void DirtyCardQueueSet::clear() {
 242   BufferNode* buffers_to_delete = NULL;
 243   {
 244     MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
 245     while (_completed_buffers_head != NULL) {
 246       BufferNode* nd = _completed_buffers_head;
 247       _completed_buffers_head = nd->next();
 248       nd->set_next(buffers_to_delete);
 249       buffers_to_delete = nd;
 250     }
 251     _n_completed_buffers = 0;
 252     _completed_buffers_tail = NULL;
 253     debug_only(assert_completed_buffer_list_len_correct_locked());
 254   }
 255   while (buffers_to_delete != NULL) {
 256     BufferNode* nd = buffers_to_delete;
 257     buffers_to_delete = nd->next();
 258     deallocate_buffer(BufferNode::make_buffer_from_node(nd));
 259   }




  53   if (cl == NULL) return true;
  54   for (size_t i = index; i < sz; i += oopSize) {
  55     int ind = byte_index_to_index((int)i);
  56     jbyte* card_ptr = (jbyte*)buf[ind];
  57     if (card_ptr != NULL) {
  58       // Set the entry to null, so we don't do it again (via the test
  59       // above) if we reconsider this buffer.
  60       if (consume) buf[ind] = NULL;
  61       if (!cl->do_card_ptr(card_ptr, worker_i)) return false;
  62     }
  63   }
  64   return true;
  65 }
  66 
  67 #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away
  68 #pragma warning( disable:4355 ) // 'this' : used in base member initializer list
  69 #endif // _MSC_VER
  70 
  71 DirtyCardQueueSet::DirtyCardQueueSet(bool notify_when_complete) :
  72   PtrQueueSet(notify_when_complete),
  73   _mut_process_closure(NULL),
  74   _shared_dirty_card_queue(this, true /*perm*/),
  75   _free_ids(NULL),
  76   _processed_buffers_mut(0), _processed_buffers_rs_thread(0)
  77 {
  78   _all_active = true;
  79 }
  80 
  81 // Determines how many mutator threads can process the buffers in parallel.
  82 uint DirtyCardQueueSet::num_par_ids() {
  83   return (uint)os::processor_count();
  84 }
  85 
  86 void DirtyCardQueueSet::initialize(CardTableEntryClosure* cl, Monitor* cbl_mon, Mutex* fl_lock,
  87                                    int process_completed_threshold,
  88                                    int max_completed_queue,
  89                                    Mutex* lock, PtrQueueSet* fl_owner) {
  90   _mut_process_closure = cl;
  91   PtrQueueSet::initialize(cbl_mon, fl_lock, process_completed_threshold,
  92                           max_completed_queue, fl_owner);
  93   set_buffer_size(G1UpdateBufferSize);
  94   _shared_dirty_card_queue.set_lock(lock);
  95   _free_ids = new FreeIdSet((int) num_par_ids(), _cbl_mon);
  96 }
  97 
  98 void DirtyCardQueueSet::handle_zero_index_for_thread(JavaThread* t) {
  99   t->dirty_card_queue().handle_zero_index();
 100 }
 101 
 102 void DirtyCardQueueSet::iterate_closure_all_threads(CardTableEntryClosure* cl,
 103                                                     bool consume,



 104                                                     uint worker_i) {
 105   assert(SafepointSynchronize::is_at_safepoint(), "Must be at safepoint.");
 106   for(JavaThread* t = Threads::first(); t; t = t->next()) {
 107     bool b = t->dirty_card_queue().apply_closure(cl, consume);
 108     guarantee(b, "Should not be interrupted.");
 109   }
 110   bool b = shared_dirty_card_queue()->apply_closure(cl,
 111                                                     consume,
 112                                                     worker_i);
 113   guarantee(b, "Should not be interrupted.");
 114 }
 115 
 116 bool DirtyCardQueueSet::mut_process_buffer(void** buf) {
 117 
 118   // Used to determine if we had already claimed a par_id
 119   // before entering this method.
 120   bool already_claimed = false;
 121 
 122   // We grab the current JavaThread.
 123   JavaThread* thread = JavaThread::current();
 124 
 125   // We get the the number of any par_id that this thread
 126   // might have already claimed.
 127   uint worker_i = thread->get_claimed_par_id();
 128 
 129   // If worker_i is not UINT_MAX then the thread has already claimed
 130   // a par_id. We make note of it using the already_claimed value
 131   if (worker_i != UINT_MAX) {
 132     already_claimed = true;
 133   } else {
 134 
 135     // Otherwise we need to claim a par id
 136     worker_i = _free_ids->claim_par_id();
 137 
 138     // And store the par_id value in the thread
 139     thread->set_claimed_par_id(worker_i);
 140   }
 141 
 142   bool b = false;
 143   if (worker_i != UINT_MAX) {
 144     b = DirtyCardQueue::apply_closure_to_buffer(_mut_process_closure, buf, 0,
 145                                                 _sz, true, worker_i);
 146     if (b) Atomic::inc(&_processed_buffers_mut);
 147 
 148     // If we had not claimed an id before entering the method
 149     // then we must release the id.
 150     if (!already_claimed) {
 151 
 152       // we release the id
 153       _free_ids->release_par_id(worker_i);
 154 
 155       // and set the claimed_id in the thread to UINT_MAX
 156       thread->set_claimed_par_id(UINT_MAX);
 157     }
 158   }
 159   return b;
 160 }
 161 
 162 
 163 BufferNode*
 164 DirtyCardQueueSet::get_completed_buffer(int stop_at) {


 199     } else {
 200       enqueue_complete_buffer(buf, index);
 201       return false;
 202     }
 203   } else {
 204     return false;
 205   }
 206 }
 207 
 208 bool DirtyCardQueueSet::apply_closure_to_completed_buffer(CardTableEntryClosure* cl,
 209                                                           uint worker_i,
 210                                                           int stop_at,
 211                                                           bool during_pause) {
 212   assert(!during_pause || stop_at == 0, "Should not leave any completed buffers during a pause");
 213   BufferNode* nd = get_completed_buffer(stop_at);
 214   bool res = apply_closure_to_completed_buffer_helper(cl, worker_i, nd);
 215   if (res) Atomic::inc(&_processed_buffers_rs_thread);
 216   return res;
 217 }
 218 
 219 void DirtyCardQueueSet::apply_closure_to_all_completed_buffers(CardTableEntryClosure* cl) {







 220   BufferNode* nd = _completed_buffers_head;
 221   while (nd != NULL) {
 222     bool b =
 223       DirtyCardQueue::apply_closure_to_buffer(cl,
 224                                               BufferNode::make_buffer_from_node(nd),
 225                                               0, _sz, false);
 226     guarantee(b, "Should not stop early.");
 227     nd = nd->next();
 228   }
 229 }
 230 
 231 void DirtyCardQueueSet::par_apply_closure_to_all_completed_buffers(CardTableEntryClosure* cl) {
 232   BufferNode* nd = _cur_par_buffer_node;
 233   while (nd != NULL) {
 234     BufferNode* next = (BufferNode*)nd->next();
 235     BufferNode* actual = (BufferNode*)Atomic::cmpxchg_ptr((void*)next, (volatile void*)&_cur_par_buffer_node, (void*)nd);
 236     if (actual == nd) {
 237       bool b =
 238         DirtyCardQueue::apply_closure_to_buffer(cl,
 239                                                 BufferNode::make_buffer_from_node(actual),
 240                                                 0, _sz, false);
 241       guarantee(b, "Should not stop early.");
 242       nd = next;
 243     } else {
 244       nd = actual;
 245     }
 246   }
 247 }
 248 
 249 // Deallocates any completed log buffers
 250 void DirtyCardQueueSet::clear() {
 251   BufferNode* buffers_to_delete = NULL;
 252   {
 253     MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
 254     while (_completed_buffers_head != NULL) {
 255       BufferNode* nd = _completed_buffers_head;
 256       _completed_buffers_head = nd->next();
 257       nd->set_next(buffers_to_delete);
 258       buffers_to_delete = nd;
 259     }
 260     _n_completed_buffers = 0;
 261     _completed_buffers_tail = NULL;
 262     debug_only(assert_completed_buffer_list_len_correct_locked());
 263   }
 264   while (buffers_to_delete != NULL) {
 265     BufferNode* nd = buffers_to_delete;
 266     buffers_to_delete = nd->next();
 267     deallocate_buffer(BufferNode::make_buffer_from_node(nd));
 268   }