< prev index next >

modules/base/src/test/java/javafx/beans/property/ReadOnlyLongWrapperTest.java

Print this page
rev 9213 : 8089557: bindBidirection works for ReadOnly*Wrapper incorrectly

*** 153,163 **** // set value once property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // set same value again property.set(VALUE_1); --- 153,163 ---- // set value once property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // set same value again property.set(VALUE_1);
*** 170,180 **** // set value twice without reading property.set(VALUE_2); property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test --- 170,180 ---- // set value twice without reading property.set(VALUE_2); property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test
*** 183,193 **** // set value once property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalChangeListener.check(readOnlyProperty, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // set same value again property.set(VALUE_1); assertEquals(VALUE_1, property.get()); --- 183,193 ---- // set value once property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalChangeListener.check(property, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // set same value again property.set(VALUE_1); assertEquals(VALUE_1, property.get());
*** 198,208 **** // set value twice without reading property.set(VALUE_2); property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_2, VALUE_1, 2); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerSet() { --- 198,208 ---- // set value twice without reading property.set(VALUE_2); property.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_2, VALUE_1, 2); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerSet() {
*** 237,247 **** // set value once property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // set same value again property.setValue(VALUE_1); --- 237,247 ---- // set value once property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // set same value again property.setValue(VALUE_1);
*** 254,264 **** // set value twice without reading property.setValue(VALUE_2); property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test --- 254,264 ---- // set value twice without reading property.setValue(VALUE_2); property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test
*** 267,277 **** // set value once property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalChangeListener.check(readOnlyProperty, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // set same value again property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); --- 267,277 ---- // set value once property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalChangeListener.check(property, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // set same value again property.setValue(VALUE_1); assertEquals(VALUE_1, property.get());
*** 282,292 **** // set value twice without reading property.setValue(VALUE_2); property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_2, VALUE_1, 2); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerSetValue() { --- 282,292 ---- // set value twice without reading property.setValue(VALUE_2); property.setValue(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_2, VALUE_1, 2); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerSetValue() {
*** 329,365 **** property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test --- 329,365 ---- property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test
*** 369,402 **** property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalChangeListener.check(readOnlyProperty, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalChangeListener.check(readOnlyProperty, VALUE_1, VALUE_2, 1); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_1, VALUE_2, 2); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_2, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerBind_primitive() { --- 369,402 ---- property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalChangeListener.check(property, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalChangeListener.check(property, VALUE_1, VALUE_2, 1); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_1, VALUE_2, 2); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_2, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerBind_primitive() {
*** 441,477 **** property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test --- 441,477 ---- property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test
*** 481,514 **** property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalChangeListener.check(readOnlyProperty, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalChangeListener.check(readOnlyProperty, VALUE_1, VALUE_2, 1); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_1, VALUE_2, 2); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(readOnlyProperty, VALUE_2, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerBind_generic() { --- 481,514 ---- property.bind(v); assertEquals(VALUE_1, property.get()); assertTrue(property.isBound()); property.check(1); ! internalChangeListener.check(property, DEFAULT, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); // change binding once v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalChangeListener.check(property, VALUE_1, VALUE_2, 1); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice without reading v.set(VALUE_1); v.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_1, VALUE_2, 2); assertEquals(VALUE_2, readOnlyProperty.get()); // change binding twice to same value v.set(VALUE_1); v.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(2); ! internalChangeListener.check(property, VALUE_2, VALUE_1, 1); assertEquals(VALUE_1, readOnlyProperty.get()); } @Test public void testPublicEagerBind_generic() {
*** 566,584 **** // rebind causes invalidation event property.bind(v2); assertEquals(VALUE_2, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change new binding v2.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change old binding v1.set(VALUE_2); --- 566,584 ---- // rebind causes invalidation event property.bind(v2); assertEquals(VALUE_2, property.get()); assertTrue(property.isBound()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change new binding v2.set(VALUE_1); assertEquals(VALUE_1, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_1, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); // change old binding v1.set(VALUE_2);
*** 621,631 **** // set value property.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(readOnlyProperty, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test --- 621,631 ---- // set value property.set(VALUE_2); assertEquals(VALUE_2, property.get()); property.check(1); ! internalInvalidationListener.check(property, 1); assertEquals(VALUE_2, readOnlyProperty.get()); publicInvalidationListener.check(readOnlyProperty, 1); } @Test
*** 639,649 **** // setting the property,checking internal property.set(VALUE_1); property.addListener(internalListener2); internalListener2.reset(); property.set(VALUE_2); ! internalListener2.check(readOnlyProperty, 1); // setting the property, checking public property.set(VALUE_1); readOnlyProperty.addListener(publicListener2); publicListener2.reset(); --- 639,649 ---- // setting the property,checking internal property.set(VALUE_1); property.addListener(internalListener2); internalListener2.reset(); property.set(VALUE_2); ! internalListener2.check(property, 1); // setting the property, checking public property.set(VALUE_1); readOnlyProperty.addListener(publicListener2); publicListener2.reset();
*** 655,665 **** v.set(VALUE_2); property.addListener(internalListener3); v.get(); internalListener3.reset(); v.set(VALUE_1); ! internalListener3.check(readOnlyProperty, 1); // binding the property, checking public property.bind(v); v.set(VALUE_2); readOnlyProperty.addListener(publicListener3); --- 655,665 ---- v.set(VALUE_2); property.addListener(internalListener3); v.get(); internalListener3.reset(); v.set(VALUE_1); ! internalListener3.check(property, 1); // binding the property, checking public property.bind(v); v.set(VALUE_2); readOnlyProperty.addListener(publicListener3);
< prev index next >