Code Review for jdk.dev

Prepared by:vromero on Thu Dec 6 13:23:06 EST 2018
Workspace:/home/vromero/work/langtoolsProjects/jdk.dev
Compare against version:52881
Summary of changes: 6704 lines changed: 6622 ins; 8 del; 74 mod; 49208 unchg
Patch of changes: jdk.dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

rev 52882 : [mq]: 8210031
70 lines changed: 69 ins; 0 del; 1 mod; 4029 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Double.java

rev 52882 : [mq]: 8210031
32 lines changed: 31 ins; 0 del; 1 mod; 1074 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Enum.java

rev 52882 : [mq]: 8210031
78 lines changed: 76 ins; 1 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Float.java

rev 52882 : [mq]: 8210031
32 lines changed: 31 ins; 0 del; 1 mod; 986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Integer.java

rev 52882 : [mq]: 8210031
32 lines changed: 31 ins; 0 del; 1 mod; 1835 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Long.java

rev 52882 : [mq]: 8210031
32 lines changed: 31 ins; 0 del; 1 mod; 1964 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/String.java

rev 52882 : [mq]: 8210031
32 lines changed: 31 ins; 0 del; 1 mod; 3540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandle.java

rev 52882 : [mq]: 8210031
64 lines changed: 63 ins; 0 del; 1 mod; 1683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodType.java

rev 52882 : [mq]: 8210031
53 lines changed: 47 ins; 2 del; 4 mod; 1380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

rev 52882 : [mq]: 8210031
214 lines changed: 207 ins; 1 del; 6 mod; 2078 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandles.java

rev 52882 : [mq]: 8210031
35 lines changed: 35 ins; 0 del; 0 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandle.java.template

rev 52882 : [mq]: 8210031
75 lines changed: 75 ins; 0 del; 0 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template

rev 52882 : [mq]: 8210031
11 lines changed: 11 ins; 0 del; 0 mod; 976 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

rev 52882 : [mq]: 8210031
1 line changed: 1 ins; 0 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/Wrapper.java

rev 52882 : [mq]: 8210031
9 lines changed: 7 ins; 1 del; 1 mod; 647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java

rev 52882 : [mq]: 8210031
18 lines changed: 12 ins; 0 del; 6 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleBaseByteArrayTest.java

rev 52882 : [mq]: 8210031
2 lines changed: 0 ins; 0 del; 2 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessByte.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessChar.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessDouble.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessFloat.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessInt.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessLong.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessShort.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessString.java

rev 52882 : [mq]: 8210031
68 lines changed: 68 ins; 0 del; 0 mod; 1238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsChar.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 906 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsDouble.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsFloat.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 1740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsLong.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 1740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort.java

rev 52882 : [mq]: 8210031
41 lines changed: 36 ins; 0 del; 5 mod; 906 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestAccess.java.template

rev 52882 : [mq]: 8210031
72 lines changed: 72 ins; 0 del; 0 mod; 1925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestByteArrayView.java.template

rev 52882 : [mq]: 8210031
45 lines changed: 40 ins; 0 del; 5 mod; 2108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/lib/JavadocTester.java

rev 52882 : [mq]: 8210031
3 lines changed: 2 ins; 0 del; 1 mod; 1795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testClassTree/TestClassTree.java

rev 52882 : [mq]: 8210031
2 lines changed: 0 ins; 1 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/TypeNameTest.java

rev 52882 : [mq]: 8210031
3 lines changed: 2 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/T8187978/FilterOutCandidatesForDiagnosticsTest.out

rev 52882 : [mq]: 8210031
1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/EnumNoSubclassing.java

rev 52882 : [mq]: 8210031
2 lines changed: 2 ins; 0 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/enum/FauxEnum1.out

rev 52882 : [mq]: 8210031
2 lines changed: 2 ins; 0 del; 0 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/inference/8176534/TestUncheckedCalls.java

rev 52882 : [mq]: 8210031
1 line changed: 0 ins; 0 del; 1 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/generics/inference/EagerReturnTypeResolution/EagerReturnTypeResolutionTestb.out

rev 52882 : [mq]: 8210031
6 lines changed: 0 ins; 0 del; 6 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lvti/harness/NonDenotableTest.java

rev 52882 : [mq]: 8210031
2 lines changed: 0 ins; 2 del; 0 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/varargs/6806876/T6806876.out

rev 52882 : [mq]: 8210031
1 line changed: 0 ins; 0 del; 1 mod; 4 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/AsTypeMethodHandleDesc.java

rev 52882 : [mq]: 8210031
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ClassDesc.java

rev 52882 : [mq]: 8210031
299 lines changed: 299 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/Constable.java

rev 52882 : [mq]: 8210031
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantDesc.java

rev 52882 : [mq]: 8210031
104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantDescs.java

rev 52882 : [mq]: 8210031
298 lines changed: 298 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ConstantUtils.java

rev 52882 : [mq]: 8210031
175 lines changed: 175 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DirectMethodHandleDesc.java

rev 52882 : [mq]: 8210031
261 lines changed: 261 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DirectMethodHandleDescImpl.java

rev 52882 : [mq]: 8210031
220 lines changed: 220 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DynamicCallSiteDesc.java

rev 52882 : [mq]: 8210031
289 lines changed: 289 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/DynamicConstantDesc.java

rev 52882 : [mq]: 8210031
397 lines changed: 397 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodHandleDesc.java

rev 52882 : [mq]: 8210031
219 lines changed: 219 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java

rev 52882 : [mq]: 8210031
201 lines changed: 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java

rev 52882 : [mq]: 8210031
173 lines changed: 173 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/PrimitiveClassDescImpl.java

rev 52882 : [mq]: 8210031
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/ReferenceClassDescImpl.java

rev 52882 : [mq]: 8210031
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/constant/package-info.java

rev 52882 : [mq]: 8210031
96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/invoke/TypeDescriptor.java

rev 52882 : [mq]: 8210031
187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/ClassDescTest.java

rev 52882 : [mq]: 8210031
279 lines changed: 279 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/CondyDescTest.java

rev 52882 : [mq]: 8210031
251 lines changed: 251 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/IndyDescTest.java

rev 52882 : [mq]: 8210031
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/MethodHandleDescTest.java

rev 52882 : [mq]: 8210031
340 lines changed: 340 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/MethodTypeDescTest.java

rev 52882 : [mq]: 8210031
246 lines changed: 246 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/NameValidationTest.java

rev 52882 : [mq]: 8210031
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/SymbolicDescTest.java

rev 52882 : [mq]: 8210031
112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/TestHelpers.java

rev 52882 : [mq]: 8210031
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/TypeDescriptorTest.java

rev 52882 : [mq]: 8210031
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/boottest/TEST.properties

rev 52882 : [mq]: 8210031
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/constant/boottest/java.base/java/lang/constant/ConstantUtilsTest.java

rev 52882 : [mq]: 8210031
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vromero/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).