Code Review for jdk.dev

Prepared by:vromero on Fri Oct 18 14:37:15 EDT 2019
Workspace:/home/vromero/work/langtoolsProjects/consolidatedJDK10Projects/jdk.dev
Compare against version:56662
Summary of changes: 10203 lines changed: 4668 ins; 0 del; 5535 mod; 45065 unchg
Patch of changes: jdk.dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/symbols/symbols-unix

rev 56663 : runtime and serviciability implementation for records
2 lines changed: 2 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

rev 56663 : runtime and serviciability implementation for records
208 lines changed: 203 ins; 0 del; 5 mod; 6347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.hpp

rev 56663 : runtime and serviciability implementation for records
9 lines changed: 9 ins; 0 del; 0 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

rev 56663 : runtime and serviciability implementation for records
116 lines changed: 116 ins; 0 del; 0 mod; 4713 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

rev 56663 : runtime and serviciability implementation for records
35 lines changed: 35 ins; 0 del; 0 mod; 1656 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

rev 56663 : runtime and serviciability implementation for records
4 lines changed: 4 ins; 0 del; 0 mod; 678 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

rev 56663 : runtime and serviciability implementation for records
4 lines changed: 4 ins; 0 del; 0 mod; 1691 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

rev 56663 : runtime and serviciability implementation for records
9 lines changed: 9 ins; 0 del; 0 mod; 1312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

rev 56663 : runtime and serviciability implementation for records
1 line changed: 1 ins; 0 del; 0 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/allocation.hpp

rev 56663 : runtime and serviciability implementation for records
2 lines changed: 1 ins; 0 del; 1 mod; 574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapInspection.hpp

rev 56663 : runtime and serviciability implementation for records
2 lines changed: 2 ins; 0 del; 0 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

rev 56663 : runtime and serviciability implementation for records
1 line changed: 1 ins; 0 del; 0 mod; 2096 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

rev 56663 : runtime and serviciability implementation for records
32 lines changed: 32 ins; 0 del; 0 mod; 4030 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

rev 56663 : runtime and serviciability implementation for records
14 lines changed: 14 ins; 0 del; 0 mod; 1447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

rev 56663 : runtime and serviciability implementation for records
48 lines changed: 48 ins; 0 del; 0 mod; 3720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmti.xml

rev 56663 : runtime and serviciability implementation for records
5534 lines changed: 5 ins; 0 del; 5529 mod; 9467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp

rev 56663 : runtime and serviciability implementation for records
58 lines changed: 58 ins; 0 del; 0 mod; 961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.hpp

rev 56663 : runtime and serviciability implementation for records
1 line changed: 1 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

rev 56663 : runtime and serviciability implementation for records
118 lines changed: 118 ins; 0 del; 0 mod; 4346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.hpp

rev 56663 : runtime and serviciability implementation for records
1 line changed: 1 ins; 0 del; 0 mod; 552 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/oops/recordComponent.cpp

rev 56663 : runtime and serviciability implementation for records
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/oops/recordComponent.hpp

rev 56663 : runtime and serviciability implementation for records
116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/records/RedefineRecord.java

rev 56663 : runtime and serviciability implementation for records
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/records/recordAttribute.jcod

rev 56663 : runtime and serviciability implementation for records
2277 lines changed: 2277 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/records/recordAttributeTest.java

rev 56663 : runtime and serviciability implementation for records
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/records/recordReflectionTest.java

rev 56663 : runtime and serviciability implementation for records
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/Host/Host.java

rev 56663 : runtime and serviciability implementation for records
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/Host/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostA/Host.java

rev 56663 : runtime and serviciability implementation for records
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostA/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostAB/Host.java

rev 56663 : runtime and serviciability implementation for records
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostAB/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostABC/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostABC/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostABCD/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostABD/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostAC/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostACB/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostB/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostBA/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostBAC/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostBCA/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostCAB/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/HostCBA/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttr/TestRecordAttr.java

rev 56663 : runtime and serviciability implementation for records
276 lines changed: 276 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/Host/Host.java

rev 56663 : runtime and serviciability implementation for records
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/Host/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/HostA/Host.java

rev 56663 : runtime and serviciability implementation for records
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/HostA/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/HostB/redef/Host.java

rev 56663 : runtime and serviciability implementation for records
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineRecordAttrGenericSig/TestRecordAttrGenericSig.java

rev 56663 : runtime and serviciability implementation for records
214 lines changed: 214 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vromero/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).