Code Review for jdk

Prepared by: Jenkins user (jenkins) on Thu Dec 15 09:19:37 UTC 2016
Workspace:/scratch/jenkins/jobs/jake-webrevs/workspace/jdk
Compare against: http://hg.openjdk.java.net/jigsaw/jake/jdk
Compare against version:jdk-9+148
Summary of changes: 4686 lines changed: 3368 ins; 757 del; 561 mod; 35444 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/java/util/jar/pack/PackerImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 610 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties

9 lines changed: 0 ins; 9 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StackTraceElement.java

17 lines changed: 10 ins; 5 del; 2 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

42 lines changed: 41 ins; 0 del; 1 mod; 5726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleDescriptor.java

242 lines changed: 109 ins; 84 del; 49 mod; 2369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleFinder.java

4 lines changed: 2 ins; 0 del; 2 mod; 391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleReference.java

183 lines changed: 2 ins; 170 del; 11 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/Resolver.java

19 lines changed: 11 ins; 2 del; 6 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

53 lines changed: 50 ins; 0 del; 3 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Layer.java

2 lines changed: 0 ins; 1 del; 1 mod; 946 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Module.java

19 lines changed: 12 ins; 1 del; 6 mod; 1566 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressor.java

5 lines changed: 4 ins; 0 del; 1 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangModuleAccess.java

39 lines changed: 8 ins; 23 del; 8 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangReflectModuleAccess.java

8 lines changed: 8 ins; 0 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Builder.java

63 lines changed: 23 ins; 28 del; 12 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Checks.java

191 lines changed: 143 ins; 22 del; 26 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ClassFileAttributes.java

232 lines changed: 106 ins; 59 del; 67 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ClassFileConstants.java

8 lines changed: 7 ins; 1 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java

86 lines changed: 81 ins; 0 del; 5 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleHashes.java

37 lines changed: 36 ins; 1 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java

17 lines changed: 13 ins; 3 del; 1 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java

7 lines changed: 0 ins; 2 del; 5 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModulePatcher.java

13 lines changed: 10 ins; 0 del; 3 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/SystemModules.java

25 lines changed: 16 ins; 5 del; 4 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

36 lines changed: 36 ins; 0 del; 0 mod; 2536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java

54 lines changed: 54 ins; 0 del; 0 mod; 1840 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Item.java

4 lines changed: 4 ins; 0 del; 0 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/Reflection.java

52 lines changed: 28 ins; 8 del; 16 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compact1/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compact2/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compact3/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java

26 lines changed: 26 ins; 0 del; 0 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/Main.java

35 lines changed: 19 ins; 6 del; 10 mod; 2364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties

2 lines changed: 2 ins; 0 del; 0 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

35 lines changed: 26 ins; 3 del; 6 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java

7 lines changed: 3 ins; 0 del; 4 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java

4 lines changed: 0 ins; 2 del; 2 mod; 785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

76 lines changed: 60 ins; 4 del; 12 mod; 1428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties

2 lines changed: 2 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/module-info.java

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.pack200/share/classes/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/MethodHandles/privateLookupIn/test/p/PrivateLookupInTests.java

2 lines changed: 0 ins; 1 del; 1 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleDescriptorTest.java

118 lines changed: 69 ins; 43 del; 6 mod; 1087 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleReader/ModuleReaderTest.java

5 lines changed: 0 ins; 2 del; 3 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleReferenceTest.java

67 lines changed: 5 ins; 57 del; 5 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Module/AnnotationsTest.java

1 line changed: 0 ins; 1 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/testlibrary/ModuleUtils.java

8 lines changed: 3 ins; 3 del; 2 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/modularJar/src/bar/jdk/test/bar/Bar.java

15 lines changed: 9 ins; 2 del; 4 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/SystemModulesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/UserModuleTest.java

1 line changed: 0 ins; 0 del; 1 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jmod/hashes/HashesTest.java

22 lines changed: 2 ins; 4 del; 16 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java

47 lines changed: 39 ins; 3 del; 5 mod; 1826 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfo.java (was src/java.base/share/classes/java/lang/module/ModuleInfo.java)

313 lines changed: 223 ins; 33 del; 57 mod; 809 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModulePath.java (was src/java.base/share/classes/java/lang/module/ModulePath.java)

23 lines changed: 6 ins; 1 del; 16 mod; 664 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java

169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleReferences.java (was src/java.base/share/classes/java/lang/module/ModuleReferences.java)

20 lines changed: 8 ins; 3 del; 9 mod; 431 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleResolution.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/SystemModuleFinder.java (was src/java.base/share/classes/java/lang/module/SystemModuleFinder.java)

216 lines changed: 100 ins; 102 del; 14 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java (was src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModuleDescriptorPlugin.java)

444 lines changed: 225 ins; 63 del; 156 mod; 864 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/invoke/DropLookupModeTest.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/module/ModuleNamesTest.java

261 lines changed: 261 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/DefaultImage.java

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/ImageModules.java

382 lines changed: 382 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/cp/listmods/ListModules.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/cp/test/ConvertToLowerCase.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/cp/test/WriteUpperCase.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/message.converter/converter/MessageConverter.java

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/message.converter/module-info.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/message.writer/module-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/modules/incubator/src/message.writer/writer/MessageWriter.java

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/CompiledVersionTest.java

129 lines changed: 129 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/src/test/jdk/test/Main.java

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/src/test/module-info.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jenkins/tools/webrev.ksh (vers 25.14-hg+openjdk.java.net).