Code Review for langtools

Prepared by:alundblad on Thu Feb 12 22:31:53 CET 2015
Workspace:/localhome/hgsrc/dev2/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Compare against version:2818
Summary of changes: 2982 lines changed: 2229 ins; 405 del; 348 mod; 9066 unchg
Changeset: langtools.changeset
Bug id: JDK-8054717 : SJavac should track changes in the public apis of classpath classes!
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java

rev 2819 : imported patch my-classpath-deps-00
1 line changed: 0 ins; 1 del; 0 mod; 724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java

rev 2819 : imported patch my-classpath-deps-00
7 lines changed: 5 ins; 2 del; 0 mod; 273 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java

rev 2819 : imported patch my-classpath-deps-00
125 lines changed: 116 ins; 0 del; 9 mod; 2799 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/BuildState.java

rev 2819 : imported patch my-classpath-deps-00
31 lines changed: 19 ins; 1 del; 11 mod; 269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/CleanProperties.java

rev 2819 : imported patch my-classpath-deps-00
17 lines changed: 12 ins; 2 del; 3 mod; 148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java

rev 2819 : imported patch my-classpath-deps-00
51 lines changed: 31 ins; 2 del; 18 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/CompileProperties.java

rev 2819 : imported patch my-classpath-deps-00
17 lines changed: 12 ins; 2 del; 3 mod; 219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/CopyFile.java

rev 2819 : imported patch my-classpath-deps-00
14 lines changed: 10 ins; 1 del; 3 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/JavacState.java

rev 2819 : imported patch my-classpath-deps-00
201 lines changed: 139 ins; 6 del; 56 mod; 801 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/Module.java

rev 2819 : imported patch my-classpath-deps-00
12 lines changed: 3 ins; 3 del; 6 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/Package.java

rev 2819 : imported patch my-classpath-deps-00
107 lines changed: 34 ins; 49 del; 24 mod; 235 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/Source.java

rev 2819 : imported patch my-classpath-deps-00
2 lines changed: 0 ins; 2 del; 0 mod; 407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/Transformer.java

rev 2819 : imported patch my-classpath-deps-00
7 lines changed: 4 ins; 1 del; 2 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/Util.java

rev 2819 : imported patch my-classpath-deps-00
23 lines changed: 23 ins; 0 del; 0 mod; 196 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/client/ClientMain.java

rev 2819 : imported patch my-classpath-deps-00
30 lines changed: 29 ins; 0 del; 1 mod; 325 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/Dependencies.java

rev 2819 : imported patch my-classpath-deps-00
158 lines changed: 57 ins; 61 del; 40 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/PathAndPackageVerifier.java

rev 2819 : imported patch my-classpath-deps-00
42 lines changed: 15 ins; 9 del; 18 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/PooledSjavac.java

rev 2819 : imported patch my-classpath-deps-00
33 lines changed: 1 ins; 23 del; 9 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java

rev 2819 : imported patch my-classpath-deps-00
123 lines changed: 40 ins; 43 del; 40 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/SjavacImpl.java

rev 2819 : imported patch my-classpath-deps-00
62 lines changed: 13 ins; 23 del; 26 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/SmartFileManager.java

rev 2819 : imported patch my-classpath-deps-00
70 lines changed: 49 ins; 14 del; 7 mod; 204 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/DependencyCollector.java

rev 2819 : imported patch my-classpath-deps-00
73 lines changed: 58 ins; 0 del; 15 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/DependencyScanner.java

rev 2819 : imported patch my-classpath-deps-00
118 lines changed: 101 ins; 0 del; 17 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/PublicApiCollector.java

rev 2819 : imported patch my-classpath-deps-00
31 lines changed: 20 ins; 1 del; 10 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/options/Options.java

rev 2819 : imported patch my-classpath-deps-00
19 lines changed: 19 ins; 0 del; 0 mod; 523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/CompilationResult.java

rev 2819 : imported patch my-classpath-deps-00
6 lines changed: 4 ins; 0 del; 2 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/ServerMain.java

rev 2819 : imported patch my-classpath-deps-00
4 lines changed: 4 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/sjavac/DependencyCollection.java

rev 2819 : imported patch my-classpath-deps-00
48 lines changed: 14 ins; 9 del; 25 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/sjavac/IncCompInheritance.java

rev 2819 : imported patch my-classpath-deps-00
1 line changed: 1 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/sjavac/JavacOptionPrep.java

rev 2819 : imported patch my-classpath-deps-00
2 lines changed: 1 ins; 1 del; 0 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/sjavac/SjavacBase.java

rev 2819 : imported patch my-classpath-deps-00
1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/tools/sjavac/test-input/src/pkg/Test.java

rev 2819 : imported patch my-classpath-deps-00
3 lines changed: 1 ins; 0 del; 2 mod; 72 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/PubApiExtractor.java

rev 2819 : imported patch my-classpath-deps-00
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/SjavacScratch.java

rev 2819 : imported patch my-classpath-deps-00
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/FileObjectWithLocation.java

rev 2819 : imported patch my-classpath-deps-00
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/JavaFileObjectWithLocation.java

rev 2819 : imported patch my-classpath-deps-00
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/ArrayTypeDesc.java

rev 2819 : imported patch my-classpath-deps-00
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PrimitiveTypeDesc.java

rev 2819 : imported patch my-classpath-deps-00
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApi.java

rev 2819 : imported patch my-classpath-deps-00
342 lines changed: 342 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApiTypeParam.java

rev 2819 : imported patch my-classpath-deps-00
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubMethod.java

rev 2819 : imported patch my-classpath-deps-00
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubType.java

rev 2819 : imported patch my-classpath-deps-00
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubVar.java

rev 2819 : imported patch my-classpath-deps-00
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/ReferenceTypeDesc.java

rev 2819 : imported patch my-classpath-deps-00
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/TypeDesc.java

rev 2819 : imported patch my-classpath-deps-00
136 lines changed: 136 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/TypeVarTypeDesc.java

rev 2819 : imported patch my-classpath-deps-00
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/sjavac/ClasspathDependencies.java

rev 2819 : imported patch my-classpath-deps-00
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/sjavac/test-input/src/pkg31/Cls31.java

rev 2819 : imported patch my-classpath-deps-00
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/tools/sjavac/test-input/src/pkg32/Cls32.java

rev 2819 : imported patch my-classpath-deps-00
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/Dependency.java

33 lines changed: 0 ins; 33 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/PackageDependency.java

41 lines changed: 0 ins; 41 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/TypeAndSupertypesDependency.java

75 lines changed: 0 ins; 75 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).