Code Review for hs25.60-b16-jdk8u60-b16

Prepared by:amurillo on Thu May 14 22:55:27 PDT 2015
Workspace:hs25.60-b16-jdk8u60-b16
Compare against: jdk8u/jdk8u
Summary of changes: 235 lines changed: 201 ins; 1 del; 33 mod; 18798 unchg
Patch of changes: hs25.60-b16-jdk8u60-b16.patch
Author comments:
8076523: assert(((ABS(iv_adjustment_in_bytes) % elt_size) == 0)) fails in superword.cpp
8078113: 8011102 changes may cause incorrect results
8078497: C2's superword optimization causes unaligned memory accesses
8079343: Crash in PhaseIdealLoop with "assert(!had_error) failed: bad dominance"
8079686: new hotspot build - hs25.60-b16
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 7352 : Added tag hs25.60-b16 for changeset f5800068c61d
1 line changed: 1 ins; 0 del; 0 mod; 643 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 7346 : 8079686: new hotspot build - hs25.60-b16
Reviewed-by: dholmes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/x86/vm/macroAssembler_x86.cpp

rev 7347 : 8078113: 8011102 changes may cause incorrect results
Summary: replace Vzeroupper instruction in stubs with zeroing only used ymm registers.
Reviewed-by: kvn
Contributed-by: sandhya.viswanathan@intel.com
11 lines changed: 6 ins; 0 del; 5 mod; 8000 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/x86/vm/stubGenerator_x86_32.cpp

rev 7347 : 8078113: 8011102 changes may cause incorrect results
Summary: replace Vzeroupper instruction in stubs with zeroing only used ymm registers.
Reviewed-by: kvn
Contributed-by: sandhya.viswanathan@intel.com
2 lines changed: 1 ins; 0 del; 1 mod; 3042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/x86/vm/stubGenerator_x86_64.cpp

rev 7347 : 8078113: 8011102 changes may cause incorrect results
Summary: replace Vzeroupper instruction in stubs with zeroing only used ymm registers.
Reviewed-by: kvn
Contributed-by: sandhya.viswanathan@intel.com
4 lines changed: 2 ins; 0 del; 2 mod; 4001 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/superword.cpp

rev 7348 : 8076523: assert(((ABS(iv_adjustment_in_bytes) % elt_size) == 0)) fails in superword.cpp
Summary: check that offset % mem_oper_size == 0 when alignment is verified during vectorization.
Reviewed-by: iveresov
rev 7349 : 8079343: Crash in PhaseIdealLoop with "assert(!had_error) failed: bad dominance"
Summary: C2 should not try to vectorize loops with loop variant vector base address.
Reviewed-by: kvn
rev 7350 : 8078497: C2's superword optimization causes unaligned memory accesses
Summary: Prevent vectorization of memory operations with different invariant offsets if unaligned memory accesses are not allowed.
Reviewed-by: kvn
70 lines changed: 47 ins; 1 del; 22 mod; 2538 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/superword.hpp

rev 7350 : 8078497: C2's superword optimization causes unaligned memory accesses
Summary: Prevent vectorization of memory operations with different invariant offsets if unaligned memory accesses are not allowed.
Reviewed-by: kvn
2 lines changed: 0 ins; 0 del; 2 mod; 530 unchg

------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/loopopts/superword/TestVectorizationWithInvariant.java

rev 7350 : 8078497: C2's superword optimization causes unaligned memory accesses
Summary: Prevent vectorization of memory operations with different invariant offsets if unaligned memory accesses are not allowed.
Reviewed-by: kvn
144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).