Code Review for open

Prepared by:ccheung on Mon Apr 2 14:12:16 PDT 2018
Workspace:/scratch/ccheung/jdk10-hs-consol/open
Compare against: ssh://hg.openjdk.java.net/jdk/hs
Summary of changes: 2053 lines changed: 1729 ins; 98 del; 226 mod; 25123 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.cpp

116 lines changed: 91 ins; 4 del; 21 mod; 2066 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.hpp

26 lines changed: 23 ins; 0 del; 3 mod; 519 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderExt.cpp

35 lines changed: 33 ins; 0 del; 2 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderExt.hpp

23 lines changed: 14 ins; 0 del; 9 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/klassFactory.cpp

1 line changed: 0 ins; 0 del; 1 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.cpp

1 line changed: 0 ins; 0 del; 1 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/sharedClassUtil.cpp

9 lines changed: 5 ins; 0 del; 4 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/sharedClassUtil.hpp

9 lines changed: 3 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

41 lines changed: 18 ins; 4 del; 19 mod; 1065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.cpp

63 lines changed: 26 ins; 1 del; 36 mod; 1054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.hpp

20 lines changed: 1 ins; 0 del; 19 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

2 lines changed: 0 ins; 1 del; 1 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

1 line changed: 0 ins; 0 del; 1 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

46 lines changed: 24 ins; 19 del; 3 mod; 4497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

5 lines changed: 5 ins; 0 del; 0 mod; 5001 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/JarBuilder.java

35 lines changed: 34 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/CheckUnsupportedDumpingOptions.java

31 lines changed: 0 ins; 25 del; 6 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/JigsawOptionsCombo.java

28 lines changed: 9 ins; 2 del; 17 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/AppClassInCP.java

8 lines changed: 1 ins; 0 del; 7 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/CustomPackage.java

7 lines changed: 3 ins; 0 del; 4 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/MismatchedPatchModule.java

51 lines changed: 3 ins; 41 del; 7 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchDir.java

3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchJavaBase.java

2 lines changed: 1 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/Simple.java

8 lines changed: 3 ins; 0 del; 5 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/SubClassOfPatchedClass.java

8 lines changed: 2 ins; 0 del; 6 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/TwoJars.java

7 lines changed: 3 ins; 0 del; 4 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/BootAppendTests.java

20 lines changed: 12 ins; 1 del; 7 mod; 248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/EmptyClassInBootClassPath.java

8 lines changed: 6 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsHelper.java

17 lines changed: 11 ins; 0 del; 6 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsTests.java

2 lines changed: 0 ins; 0 del; 2 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/test-classes/JvmtiApp.java

23 lines changed: 7 ins; 0 del; 16 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleCDS.java

7 lines changed: 3 ins; 0 del; 4 mod; 101 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddModules.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddOpens.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddReads.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ExportModule.java

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java

156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/MainModuleOnly.java

171 lines changed: 171 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/com/greetings/Main.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/module-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/com/hello/Main.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/module-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.nomodule/com/nomodule/Main.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/com/norequires/Main.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/module-info.java

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/com/simple/Main.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/module-info.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/module-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/org/astro/World.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../bldenv/hg_webrev (vers 23.18-hg-never).