Code Review for jdk11u-dev

Prepared by:clanger on Fri Jun 28 07:26:46 CEST 2019
Workspace:
Compare against version:51971
Summary of changes: 540 lines changed: 421 ins; 62 del; 57 mod; 8855 unchg
Patch of changes: jdk11u-dev.patch
Bug id: JDK-8215694 : keytool cannot generate RSASSA-PSS certificates
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/spec/PSSParameterSpec.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
12 lines changed: 10 ins; 1 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/pkcs10/PKCS10.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
7 lines changed: 4 ins; 1 del; 2 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/rsa/PSSParameters.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
136 lines changed: 59 ins; 40 del; 37 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
rev 51973 : 8215694 resolve
44 lines changed: 25 ins; 14 del; 5 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/tools/keytool/Main.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
rev 51973 : 8215694 resolve
18 lines changed: 11 ins; 1 del; 6 mod; 4681 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/AlgorithmId.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
89 lines changed: 87 ins; 0 del; 2 mod; 1076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/X509CertImpl.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
rev 51973 : 8215694 resolve
9 lines changed: 0 ins; 5 del; 4 mod; 2011 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/sun/security/tools/keytool/PSS.java

rev 51972 : 8215694: keytool cannot generate RSASSA-PSS certificates
Reviewed-by: xuelei
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/security/DerUtils.java

rev 51973 : 8215694 resolve
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/SAPDevelop/mercurial/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).