Code Review for jdk

Prepared by:darcy on Thu Dec 3 16:46:06 PST 2009
Workspace:/home/darcy/Sun/OpenJDK/7/tl/tl/jdk
Compare against: http://hg.openjdk.java.net/jdk7/tl/jdk
Summary of changes: 179 lines changed: 0 ins; 130 del; 49 mod; 20662 unchg
Patch of changes: jdk.patch
Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/CpuOldTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/CpuSamplesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/CpuTimesDefineClassTest.java

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/CpuTimesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/HeapAllTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/HeapBinaryFormatTest.java

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/HeapDumpTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/HeapSitesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/demo/jvmti/hprof/OptionsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/array/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/badResolve/Write.java

2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/basic/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/classObject/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/constantSubclasses/Write.java

2 lines changed: 0 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/ignoreSerializationFields/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/mismatchedTypecode/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/missingConstant/Write.java

2 lines changed: 0 ins; 0 del; 2 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/enum/unshared/Test.java

3 lines changed: 0 ins; 3 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Boolean/MakeBooleanComparable.java

3 lines changed: 0 ins; 3 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/Cast.java

3 lines changed: 0 ins; 3 del; 0 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/IsEnum.java

2 lines changed: 0 ins; 2 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/asSubclass/BasicUnit.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/ClassLoader/Assert.sh

1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Integer/BitTwiddle.java

3 lines changed: 0 ins; 3 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Long/BitTwiddle.java

3 lines changed: 0 ins; 3 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Math/Atan2Tests.java

2 lines changed: 0 ins; 2 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Math/IeeeRecommendedTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 1703 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Math/PowTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Math/TanTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Runtime/exec/WinCommand.java

3 lines changed: 0 ins; 3 del; 0 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Thread/GenerifyStackTraces.java

3 lines changed: 0 ins; 3 del; 0 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Thread/UncaughtExceptions.sh

1 line changed: 0 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/annotation/UnitTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 4981 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/annotation/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java

1 line changed: 0 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/CompositeData/ThreadInfoCompositeData.java

1 line changed: 0 ins; 0 del; 1 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/ManagementFactory/MXBeanProxyTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/ManagementFactory/ProxyExceptions.java

3 lines changed: 0 ins; 3 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/ManagementFactory/ProxyTypeMapping.java

1 line changed: 0 ins; 0 del; 1 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/ManagementFactory/ValidateOpenTypes.java

1 line changed: 0 ins; 0 del; 1 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/RuntimeMXBean/GetSystemProperties.java

3 lines changed: 0 ins; 3 del; 0 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/management/RuntimeMXBean/TestInputArgument.sh

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Constructor/GenericStringTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Field/GenericStringTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/StringsAndBounds.java

2 lines changed: 0 ins; 2 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/TestC1.java

1 line changed: 0 ins; 0 del; 1 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/TestC2.java

1 line changed: 0 ins; 0 del; 1 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/TestN1.java

1 line changed: 0 ins; 0 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/exceptionCauseTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Generics/getAnnotationTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Method/Equals.java

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Method/GenericStringTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigDecimal/DivideTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigDecimal/IntegralDivisionTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigDecimal/PowTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigDecimal/ToPlainStringTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/BigDecimal/ZeroScalingTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 464 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/math/RoundingMode/RoundingModeTests.java

2 lines changed: 0 ins; 2 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/ProxySelector/ProxyTest.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URL/PerConnectionProxy.java

1 line changed: 0 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/cert/PKIXParameters/InvalidParameters.java

1 line changed: 0 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/AbstractList/CheckForComodification.java

2 lines changed: 0 ins; 2 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collections/AddAll.java

3 lines changed: 0 ins; 3 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collections/Disjoint.java

3 lines changed: 0 ins; 3 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Collections/Frequency.java

3 lines changed: 0 ins; 3 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumMap/EnumMapBash.java

3 lines changed: 0 ins; 3 del; 0 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumSet/AllOf.java

3 lines changed: 0 ins; 3 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumSet/ComplementOf.java

3 lines changed: 0 ins; 3 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumSet/EnumSetBash.java

3 lines changed: 0 ins; 3 del; 0 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumSet/JumboRange.java

3 lines changed: 0 ins; 3 del; 0 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/EnumSet/Range.java

3 lines changed: 0 ins; 3 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Formattable/StockName.java

3 lines changed: 0 ins; 2 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/IdentityHashMap/ToString.java

3 lines changed: 0 ins; 3 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Locale/Bug4175998Test.java

1 line changed: 0 ins; 0 del; 1 mod; 862 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/UUID/UUIDTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/ConcurrentHashMap/MapCheck.java

1 line changed: 0 ins; 0 del; 1 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/ConcurrentHashMap/MapLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/Exchanger/ExchangeLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/FutureTask/CancelledFutureLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/atomic/VMSupportsCS8.java

2 lines changed: 0 ins; 2 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java

2 lines changed: 0 ins; 2 del; 0 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java

1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/management/AgentCheckTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/util/Oid/S11N.sh

1 line changed: 0 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/tools/jconsole/ResourceCheckTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

This code review page was prepared using /home/darcy/Sun/OpenJDK/bin/webrev (vers 23.18-hg).