Code Review for open

Prepared by:dholmes on Fri Oct 13 02:06:58 EDT 2017
Workspace:/export/users/dh198349/valhalla/repos/valhalla-dev/open
Compare against: ssh://hg.openjdk.java.net/valhalla/valhalla
Branch:nestmates
Summary of changes: 463 lines changed: 6 ins; 7 del; 450 mod; 25625 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

12 lines changed: 0 ins; 0 del; 12 mod; 6249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.hpp

1 line changed: 0 ins; 0 del; 1 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1655 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

35 lines changed: 0 ins; 0 del; 35 mod; 3873 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

12 lines changed: 0 ins; 0 del; 12 mod; 1519 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Attribute.java

5 lines changed: 0 ins; 0 del; 5 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java

4 lines changed: 0 ins; 0 del; 4 mod; 1932 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java

5 lines changed: 2 ins; 2 del; 1 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java

6 lines changed: 3 ins; 3 del; 0 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java

4 lines changed: 1 ins; 1 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersEntry.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersLength.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestMember.jcod

4 lines changed: 0 ins; 0 del; 4 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/DuplicateNestMemberEntry.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TestNestmateAttributes.java

10 lines changed: 0 ins; 0 del; 10 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestMembers.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/NotAMember.jcod

4 lines changed: 0 ins; 0 del; 4 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/NotAMember2.java

2 lines changed: 0 ins; 0 del; 2 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/NotAMember2.jcod

4 lines changed: 0 ins; 0 del; 4 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java

32 lines changed: 0 ins; 0 del; 32 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestInvokeSpecial.java

3 lines changed: 0 ins; 0 del; 3 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestMethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestReflection.java

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateFields/TestMethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateFields/TestPrivateField.java

2 lines changed: 0 ins; 0 del; 2 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateFields/TestReflection.java

2 lines changed: 0 ins; 0 del; 2 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethod.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethodWithSuper.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceError.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceGood.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvoke.java

2 lines changed: 0 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeErrors.java

6 lines changed: 0 ins; 0 del; 6 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestMethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestReflection.java

2 lines changed: 0 ins; 0 del; 2 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestMethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestPrivateStaticField.java

2 lines changed: 0 ins; 0 del; 2 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestReflection.java

2 lines changed: 0 ins; 0 del; 2 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestInvokeStatic.java

2 lines changed: 0 ins; 0 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestMethodHandles.java

2 lines changed: 0 ins; 0 del; 2 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestReflection.java

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java

1 line changed: 0 ins; 0 del; 1 mod; 1456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/MethodParameters/AttributeVisitor.java

1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/nestmate/CheckNestmateAttrs.java

6 lines changed: 0 ins; 1 del; 5 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/NestHost_attribute.java (was src/jdk.jdeps/share/classes/com/sun/tools/classfile/MemberOfNest_attribute.java)

6 lines changed: 0 ins; 0 del; 6 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestTop.jcod)

23 lines changed: 0 ins; 0 del; 23 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestTop.jcod)

24 lines changed: 0 ins; 0 del; 24 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoMemberOfNest.jcod)

11 lines changed: 0 ins; 0 del; 11 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/ArrayNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/membership/ArrayNestTop.jcod)

39 lines changed: 0 ins; 0 del; 39 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/MissingNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/membership/MissingNestTop.jcod)

37 lines changed: 0 ins; 0 del; 37 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.java (was test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestTop.java)

3 lines changed: 0 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestTop.jcod)

29 lines changed: 0 ins; 0 del; 29 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2.java (was test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestTop2.java)

3 lines changed: 0 ins; 0 del; 3 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2Member.jcod (was test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestTop2Member.jcod)

39 lines changed: 0 ins; 0 del; 39 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingNestHost.jcod (was test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingNestTop.jcod)

38 lines changed: 0 ins; 0 del; 38 mod; 108 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).