Code Review for jdk7-hotspot

Prepared by:Gary Benson on Thu Oct 8 17:31:34 BST 2009
Workspace:/home/gary/work/jdk7-hotspot
Summary of changes: 7669 lines changed: 7613 ins; 10 del; 46 mod; 19241 unchg
Patch of changes: jdk7-hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/Makefile

35 lines changed: 34 ins; 0 del; 1 mod; 508 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/defs.make

4 lines changed: 2 ins; 0 del; 2 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/Makefile

41 lines changed: 34 ins; 0 del; 7 mod; 305 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/buildtree.make

17 lines changed: 11 ins; 0 del; 6 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/defs.make

25 lines changed: 13 ins; 0 del; 12 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/gcc.make

4 lines changed: 4 ins; 0 del; 0 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/sa.make

2 lines changed: 0 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/saproc.make

2 lines changed: 0 ins; 0 del; 2 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/top.make

1 line changed: 1 ins; 0 del; 0 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/vm.make

13 lines changed: 11 ins; 0 del; 2 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/os/linux/vm/os_linux.cpp

30 lines changed: 27 ins; 0 del; 3 mod; 4841 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3046 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/interpreter/oopMapCache.cpp

1 line changed: 0 ins; 0 del; 1 mod; 642 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/arguments.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 2912 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/globals.hpp

1 line changed: 0 ins; 1 del; 0 mod; 3429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/jniHandles.hpp

4 lines changed: 4 ins; 0 del; 0 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/mutex.hpp

9 lines changed: 0 ins; 8 del; 1 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/signature.hpp

9 lines changed: 6 ins; 1 del; 2 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/vm_version.cpp

11 lines changed: 8 ins; 0 del; 3 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/utilities/vmError.cpp

35 lines changed: 35 ins; 0 del; 0 mod; 884 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/make/linux/makefiles/zero.make

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/make/linux/makefiles/zeroshark.make

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/make/linux/platform_zero.in

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/assembler_zero.cpp

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/assembler_zero.hpp

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/assembler_zero.inline.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytecodeInterpreter_zero.cpp

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytecodeInterpreter_zero.hpp

150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytecodeInterpreter_zero.inline.hpp

301 lines changed: 301 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytecodes_zero.cpp

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytecodes_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/bytes_zero.hpp

164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/codeBuffer_zero.hpp

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/copy_zero.hpp

178 lines changed: 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp

946 lines changed: 946 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/cppInterpreter_zero.hpp

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/debug_zero.cpp

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/depChecker_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/depChecker_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/disassembler_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/disassembler_zero.hpp

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/dump_zero.cpp

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/entryFrame_zero.hpp

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/entry_zero.hpp

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/fakeStubFrame_zero.hpp

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/frame_zero.cpp

414 lines changed: 414 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/frame_zero.hpp

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/frame_zero.inline.hpp

151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/globalDefinitions_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/globals_zero.hpp

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/icBuffer_zero.cpp

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/icache_zero.cpp

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/icache_zero.hpp

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interp_masm_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interp_masm_zero.hpp

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreterFrame_zero.hpp

75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreterGenerator_zero.hpp

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreterRT_zero.cpp

162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreterRT_zero.hpp

127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreter_zero.cpp

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interpreter_zero.hpp

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/javaFrameAnchor_zero.hpp

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/jniFastGetField_zero.cpp

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/jniTypes_zero.hpp

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/jni_zero.h

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/methodHandles_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/nativeInst_zero.cpp

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/nativeInst_zero.hpp

185 lines changed: 185 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/registerMap_zero.hpp

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/register_definitions_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/register_zero.cpp

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/register_zero.hpp

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/relocInfo_zero.cpp

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/relocInfo_zero.hpp

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/sharedRuntime_zero.cpp

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/sharkFrame_zero.hpp

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/stack_zero.hpp

197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/stubGenerator_zero.cpp

251 lines changed: 251 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/stubRoutines_zero.cpp

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/stubRoutines_zero.hpp

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateInterpreterGenerator_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateTable_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateTable_zero.hpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vmStructs_zero.hpp

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vm_version_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vm_version_zero.hpp

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vmreg_zero.cpp

62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vmreg_zero.hpp

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vmreg_zero.inline.hpp

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/vtableStubs_zero.cpp

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/assembler_linux_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp

293 lines changed: 293 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/bytes_linux_zero.inline.hpp

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/globals_linux_zero.hpp

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/orderAccess_linux_zero.inline.hpp

167 lines changed: 167 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.cpp

456 lines changed: 456 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.hpp

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/prefetch_linux_zero.inline.hpp

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/threadLS_linux_zero.hpp

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/thread_linux_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/thread_linux_zero.hpp

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/os_cpu/linux_zero/vm/vm_version_linux_zero.cpp

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/src/share/vm/includeDB_zero

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/gary/bin/webrev (vers 23.18-hg).