Code Review for ndmp-stage-hotspot

Prepared by:goetz on Fri Nov 22 16:34:35 CET 2013
Workspace:/net/usr.work/d045726/oJ/ndmp-stage-hotspot
Compare against: http://hg.openjdk.java.net/ppc-aix-port/stage/hotspot
Compare against version:5725
Summary of changes: 14 lines changed: 3 ins; 2 del; 9 mod; 14328 unchg
Changeset: ndmp-stage-hotspot.changeset
Author comments:

To allow some special cases when dumping debug information about IR nodes, _in_dump_cnt can be increased. Unfortunately this is a global field. If running with more than one compiler thread races can happen. As consequence, dumping crashes e.g. in MachProjNode::adr_type().

This change moves the field to the Compile object.

It also introduces the compiler oracle 'option' feature for PrintAssembly.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/code/nmethod.cpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
1 line changed: 0 ins; 0 del; 1 mod; 2949 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.cpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
2 lines changed: 0 ins; 0 del; 2 mod; 1761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.cpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
2 lines changed: 2 ins; 0 del; 0 mod; 3964 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.hpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
1 line changed: 1 ins; 0 del; 0 mod; 1186 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/idealGraphPrinter.cpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
2 lines changed: 0 ins; 0 del; 2 mod; 739 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.cpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
4 lines changed: 0 ins; 1 del; 3 mod; 2129 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.hpp

rev 5726 : 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.
Summary: Also introduces the compiler oracle 'option' feature for PrintAssembly.
2 lines changed: 0 ins; 1 del; 1 mod; 1600 unchg

This code review page was prepared using /sapmnt/home1/d045726/bin/webrev.ksh (vers 24.0-hg+jbs).