Code Review for jmc

Prepared by:hirt hirt on Wed Feb 27 20:13:14 CET 2019
Workspace:/Users/marcus/hg/openjdk/jmc
Compare against: ssh://hg.openjdk.java.net/jmc/jmc
Summary of changes: 569 lines changed: 28 ins; 1 del; 540 mod; 9361 unchg
Patch of changes: jmc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.browser/build.properties

1 line changed: 0 ins; 1 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.flightrecorder.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/ui/scripts/TokenizerTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/GreyChartPanelTester.java

4 lines changed: 0 ins; 0 del; 4 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/PieChartTester.java

5 lines changed: 0 ins; 0 del; 5 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/RenderingOutOfOrderTester.java

8 lines changed: 0 ins; 0 del; 8 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.greychart.test/src/test/java/org/openjdk/jmc/greychart/testutil/RenderingPerformanceTester.java

12 lines changed: 0 ins; 0 del; 12 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java

2 lines changed: 0 ins; 0 del; 2 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrControlTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrPackageExampleTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/JfrTestCase.java

3 lines changed: 0 ins; 0 del; 3 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.services.jfr.test/src/test/java/org/openjdk/jmc/rjmx/services/jfr/test/RecordingOptionsTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/BasicCommunicationTest.java

10 lines changed: 0 ins; 0 del; 10 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/DefaultServicesTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/PackageExampleTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/RjmxTestCase.java

18 lines changed: 0 ins; 0 del; 18 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/RJMXConnectionTest.java

14 lines changed: 0 ins; 0 del; 14 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/RJMXProxyOperationsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/internal/TabularDataBeanTestMBean.java

23 lines changed: 0 ins; 0 del; 23 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/services/CommercialFeaturesServiceTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/services/ServicesPackageExampleTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeDescriptorTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeSubscriptionTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/AttributeValueTest.java

6 lines changed: 0 ins; 0 del; 6 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/CompositeDataSubscriptionTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JRockitPerfCounterMBeanTest.java

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JmxOperatingSystemTest.java

10 lines changed: 0 ins; 0 del; 10 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/JmxThreadTest.java

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MRIMetadataServiceTest.java

43 lines changed: 0 ins; 0 del; 43 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MRIMetadataToolkitTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/MultipleAttributeSubscriptionTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/NotificationAttributeSubscriptionTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/ConsoleAttributeInfoManagerTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/DummyConnectionHandle.java

3 lines changed: 0 ins; 0 del; 3 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/subscription/internal/UpdatePolicyTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/PropertyTestAttribute.java

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/SyntheticAttributesTest.java

37 lines changed: 0 ins; 0 del; 37 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/SyntheticNotificationTest.java

15 lines changed: 0 ins; 0 del; 15 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/synthetic/TestAttribute.java

2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/testutil/JVMKeepAlive.java

7 lines changed: 0 ins; 0 del; 7 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/testutil/TestToolkit.java

2 lines changed: 0 ins; 0 del; 2 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationActionCallback.java

2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationModelTest.java

5 lines changed: 0 ins; 0 del; 5 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/triggers/NotificationTriggerAndRuleTest.java

13 lines changed: 0 ins; 0 del; 13 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.ui.common.test/src/test/java/org/openjdk/jmc/ui/common/jvm/JVMCommandLineToolkitTest.java

21 lines changed: 0 ins; 0 del; 21 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.ui.common.test/src/test/java/org/openjdk/jmc/ui/common/security/SecureStoreTest.java

10 lines changed: 0 ins; 0 del; 10 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/fields/FilterMatcherTest.java

23 lines changed: 0 ins; 0 del; 23 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/util/ProgressCircleTester.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/TestRunner.java

2 lines changed: 0 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/mbeanhelpers/Testable.java

23 lines changed: 0 ins; 0 del; 23 mod; 900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/TestHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java

3 lines changed: 0 ins; 0 del; 3 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestJFRTransformer.java

1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestToolkit.java

6 lines changed: 0 ins; 0 del; 6 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestVisitor.java

13 lines changed: 0 ins; 0 del; 13 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/BinaryPrefixTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/MCTestCase.java

20 lines changed: 0 ins; 0 del; 20 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/mock/item/MockAttributes.java

3 lines changed: 0 ins; 0 del; 3 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/mock/item/MockCollections.java

1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/string/StringToolkitTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/ContentTypeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/util/BoundedListTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/version/JavaVMVersionToolkitTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/version/JavaVersionTest.java

34 lines changed: 0 ins; 0 del; 34 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/JfrAttributesTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/MetadataEventLocationUpdateTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/StacktraceBaselineGenerator.java

4 lines changed: 0 ins; 0 del; 4 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/StacktraceTestToolkit.java

1 line changed: 0 ins; 0 del; 1 mod; 202 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.flightrecorder.ui.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.greychart.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.rjmx.services.jfr.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.rjmx.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.ui.common.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/tests/org.openjdk.jmc.ui.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.common.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/.settings/org.eclipse.jdt.core.prefs

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.rules.test/.settings/org.eclipse.jdt.core.prefs

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/.settings/org.eclipse.jdt.core.prefs

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).