Code Review for jdkhs-heap-event

Prepared by:jcbeyler on Wed Apr 11 14:31:54 PDT 2018
Workspace:/usr/local/google/home/jcbeyler/mercurial/jdkhs-heap-event
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version:49642
Summary of changes: 3441 lines changed: 3308 ins; 15 del; 118 mod; 147765 unchg
Changeset: jdkhs-heap-event.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/nb_native/nbproject/configurations.xml

rev 49643 : [mq]: heap8
8 lines changed: 8 ins; 0 del; 0 mod; 40886 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
2 lines changed: 0 ins; 0 del; 2 mod; 5666 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 3264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/templateTable_arm.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 5025 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 5360 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/templateTable_ppc_64.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 4274 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/macroAssembler_s390.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 7471 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/templateTable_s390.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 4369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
2 lines changed: 0 ins; 0 del; 2 mod; 5062 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/templateTable_sparc.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 3726 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
2 lines changed: 0 ins; 0 del; 2 mod; 11299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 4576 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 49643 : [mq]: heap8
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
26 lines changed: 25 ins; 0 del; 1 mod; 634 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

rev 49643 : [mq]: heap8
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49647 : [mq]: heap12
rev 49648 : [mq]: heap13
16 lines changed: 10 ins; 0 del; 6 mod; 296 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49649 : [mq]: heap14
54 lines changed: 50 ins; 0 del; 4 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49649 : [mq]: heap14
24 lines changed: 16 ins; 1 del; 7 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 995 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/macro.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
2 lines changed: 0 ins; 0 del; 2 mod; 2798 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/runtime.cpp

rev 49643 : [mq]: heap8
rev 49646 : [mq]: heap11
8 lines changed: 8 ins; 0 del; 0 mod; 1665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmti.xml

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
114 lines changed: 110 ins; 0 del; 4 mod; 14829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEnv.cpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
27 lines changed: 26 ins; 1 del; 0 mod; 3711 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 49643 : [mq]: heap8
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
4 lines changed: 3 ins; 0 del; 1 mod; 1076 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49647 : [mq]: heap12
rev 49648 : [mq]: heap13
174 lines changed: 139 ins; 7 del; 28 mod; 2817 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49646 : [mq]: heap11
rev 49647 : [mq]: heap12
rev 49648 : [mq]: heap13
59 lines changed: 46 ins; 5 del; 8 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiManageCapabilities.cpp

rev 49643 : [mq]: heap8
rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49648 : [mq]: heap13
3 lines changed: 3 ins; 0 del; 0 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.cpp

rev 49643 : [mq]: heap8
1 line changed: 1 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 49643 : [mq]: heap8
8 lines changed: 8 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
5 lines changed: 5 ins; 0 del; 0 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 49644 : [mq]: event_rebased
rev 49646 : [mq]: heap11
1 line changed: 1 ins; 0 del; 0 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 49643 : [mq]: heap8
3 lines changed: 2 ins; 1 del; 0 mod; 5000 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
6 lines changed: 4 ins; 0 del; 2 mod; 2227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 49643 : [mq]: heap8
rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 3491 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java

rev 49649 : [mq]: heap14
1 line changed: 0 ins; 0 del; 1 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ThreadLocalAllocBuffer.java

rev 49649 : [mq]: heap14
7 lines changed: 0 ins; 0 del; 7 mod; 107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java

rev 49649 : [mq]: heap14
3 lines changed: 0 ins; 0 del; 3 mod; 838 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java

rev 49649 : [mq]: heap14
6 lines changed: 1 ins; 0 del; 5 mod; 397 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java

rev 49649 : [mq]: heap14
6 lines changed: 0 ins; 0 del; 6 mod; 1019 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java

rev 49649 : [mq]: heap14
13 lines changed: 0 ins; 0 del; 13 mod; 750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/NewInstanceStub.java

rev 49649 : [mq]: heap14
3 lines changed: 0 ins; 0 del; 3 mod; 309 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.cpp

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49647 : [mq]: heap12
170 lines changed: 170 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.hpp

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/Frame.java

rev 49644 : [mq]: event_rebased
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
172 lines changed: 172 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorArrayAllSampledTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventOnOffTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventsForTwoThreadsTest.java

rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCParallelTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCSerialTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorIllegalArgumentTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterArrayTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorNoCapabilityTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49649 : [mq]: heap14
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatSimpleTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadOnOffTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest.java

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTwoAgentsTest.java

rev 49648 : [mq]: heap13
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorVMEventsTest.java

rev 49649 : [mq]: heap14
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/ThreadInformation.java

rev 49645 : [mq]: heap9
rev 49648 : [mq]: heap13
186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c

rev 49644 : [mq]: event_rebased
rev 49645 : [mq]: heap9
rev 49646 : [mq]: heap11
rev 49648 : [mq]: heap13
rev 49649 : [mq]: heap14
927 lines changed: 927 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).