Code Review for open

Prepared by:kbarrett on Mon Jun 11 16:16:26 EDT 2018
Workspace:/home/kab/sandboxes/remove_in_archive_root/jdk/open
Compare against version:qparent
Summary of changes: 97 lines changed: 39 ins; 26 del; 32 mod; 18268 unchg
Patch of changes: open.patch
Bug id: JDK-8204585 : Remove IN_ARCHIVE_ROOT from Access API
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
26 lines changed: 14 ins; 5 del; 7 mod; 4562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
3 lines changed: 1 ins; 0 del; 2 mod; 1554 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BarrierSet.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
1 line changed: 0 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
9 lines changed: 0 ins; 1 del; 8 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
13 lines changed: 13 ins; 0 del; 0 mod; 4971 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
2 lines changed: 2 ins; 0 del; 0 mod; 1448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
6 lines changed: 5 ins; 0 del; 1 mod; 2171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
1 line changed: 1 ins; 0 del; 0 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/access.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
2 lines changed: 0 ins; 1 del; 1 mod; 385 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/accessDecorators.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
9 lines changed: 0 ins; 6 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

rev 50453 : imported patch 02.removeInArchiveRoot
7 lines changed: 1 ins; 1 del; 5 mod; 828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

rev 50453 : imported patch 02.removeInArchiveRoot
rev 50454 : imported patch cleanups
17 lines changed: 2 ins; 11 del; 4 mod; 837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

rev 50453 : imported patch 02.removeInArchiveRoot
1 line changed: 0 ins; 1 del; 0 mod; 761 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).