Code Review for rt

Prepared by:kcr on Mon Mar 14 19:20:25 PDT 2016
Workspace:/localhome/kcr/javafx/9/jfx/rt
Compare against: http://hg.openjdk.java.net/openjfx/9/rt
Compare against version:9618
Summary of changes: 5642 lines changed: 3502 ins; 1978 del; 162 mod; 13710 unchg
Changeset: rt.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
21 lines changed: 2 ins; 2 del; 17 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractImageBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
181 lines changed: 0 ins; 179 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/BasicBundlers.java

rev 9619 : imported patch 9-jake-fxpackager.patch
33 lines changed: 0 ins; 32 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/BundlerParamInfo.java

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 1 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/Bundlers.java

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 1 ins; 0 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/StandardBundlerParam.java

rev 9619 : imported patch 9-jake-fxpackager.patch
45 lines changed: 37 ins; 1 del; 7 mod; 759 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
219 lines changed: 9 ins; 205 del; 5 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
846 lines changed: 12 ins; 799 del; 35 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppStoreBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
76 lines changed: 1 ins; 72 del; 3 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacBaseInstallerBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
147 lines changed: 1 ins; 143 del; 3 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinAppBundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
425 lines changed: 9 ins; 403 del; 13 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/Application.java

rev 9619 : imported patch 9-jake-fxpackager.patch
94 lines changed: 93 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/DeployFXTask.java

rev 9619 : imported patch 9-jake-fxpackager.patch
16 lines changed: 15 ins; 0 del; 1 mod; 645 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

rev 9619 : imported patch 9-jake-fxpackager.patch
47 lines changed: 45 ins; 0 del; 2 mod; 728 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Main.java

rev 9619 : imported patch 9-jake-fxpackager.patch
31 lines changed: 29 ins; 1 del; 1 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/PackagerLib.java

rev 9619 : imported patch 9-jake-fxpackager.patch
53 lines changed: 18 ins; 13 del; 22 mod; 917 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

rev 9619 : imported patch 9-jake-fxpackager.patch
47 lines changed: 26 ins; 20 del; 1 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/Bundler.java

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/javapackager/shell/javapackager

rev 9619 : imported patch 9-jake-fxpackager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/GenericPlatform.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 1 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Helpers.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
40 lines changed: 40 ins; 0 del; 0 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Helpers.h

rev 9619 : imported patch 9-jake-fxpackager.patch
2 lines changed: 2 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/JavaVirtualMachine.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
15 lines changed: 13 ins; 0 del; 2 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Package.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
9 lines changed: 9 ins; 0 del; 0 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Package.h

rev 9619 : imported patch 9-jake-fxpackager.patch
2 lines changed: 2 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Platform.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
4 lines changed: 4 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/Platform.h

rev 9619 : imported patch 9-jake-fxpackager.patch
148 lines changed: 147 ins; 0 del; 1 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
92 lines changed: 92 ins; 0 del; 0 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.h

rev 9619 : imported patch 9-jake-fxpackager.patch
6 lines changed: 6 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.cpp

rev 9619 : imported patch 9-jake-fxpackager.patch
15 lines changed: 15 ins; 0 del; 0 mod; 829 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.h

rev 9619 : imported patch 9-jake-fxpackager.patch
3 lines changed: 3 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/windows/WinAppBundler.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 0 ins; 1 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppBundlerTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
14 lines changed: 0 ins; 0 del; 14 mod; 819 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppStoreBundlerTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
4 lines changed: 0 ins; 0 del; 4 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacDaemonBundlerTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
2 lines changed: 0 ins; 1 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacDmgBundlerTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
8 lines changed: 0 ins; 0 del; 8 mod; 471 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacPkgBundlerTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
8 lines changed: 0 ins; 0 del; 8 mod; 677 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/hello/SimpleBundle.java

rev 9619 : imported patch 9-jake-fxpackager.patch
8 lines changed: 5 ins; 1 del; 2 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackager/src/test/java/hello/TestPackager.java

rev 9619 : imported patch 9-jake-fxpackager.patch
18 lines changed: 17 ins; 0 del; 1 mod; 181 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/make/build.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/JDepHelper.java

rev 9619 : imported patch 9-jake-fxpackager.patch
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/JLinkBundlerHelper.java

rev 9619 : imported patch 9-jake-fxpackager.patch
328 lines changed: 328 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/Module.java

rev 9619 : imported patch 9-jake-fxpackager.patch
144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/ModuleManager.java

rev 9619 : imported patch 9-jake-fxpackager.patch
120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/jdk/packager/builders/AbstractAppImageBuilder.java

rev 9619 : imported patch 9-jake-fxpackager.patch
267 lines changed: 267 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/jdk/packager/builders/linux/LinuxAppImageBuilder.java

rev 9619 : imported patch 9-jake-fxpackager.patch
248 lines changed: 248 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/jdk/packager/builders/mac/MacAppImageBuilder.java

rev 9619 : imported patch 9-jake-fxpackager.patch
873 lines changed: 873 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/java/jdk/packager/builders/windows/WindowsAppImageBuilder.java

rev 9619 : imported patch 9-jake-fxpackager.patch
458 lines changed: 458 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/module-info/module-info.java

rev 9619 : imported patch 9-jake-fxpackager.patch
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/JLinkBundlerHelper.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/mac/Runtime-Info.plist.template

rev 9619 : imported patch 9-jake-fxpackager.patch
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/jdk/packager/builders/AbstractAppImageBuilder.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/jdk/packager/builders/linux/LinuxAppImageBuilder.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/jdk/packager/builders/mac/MacAppImageBuilder.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackager/src/main/resources/jdk/packager/builders/windows/WindowsAppImageBuilder.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
15 lines changed: 15 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackagerservices/make/build.properties

rev 9619 : imported patch 9-jake-fxpackager.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/UserJvmOptionsService.java (was modules/fxpackager/src/main/java/jdk/packager/services/UserJvmOptionsService.java)

rev 9619 : imported patch 9-jake-fxpackager.patch
6 lines changed: 0 ins; 2 del; 4 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/userjvmoptions/LauncherUserJvmOptions.java (was modules/fxpackager/src/main/java/jdk/packager/services/userjvmoptions/LauncherUserJvmOptions.java)

rev 9619 : imported patch 9-jake-fxpackager.patch
1 line changed: 1 ins; 0 del; 0 mod; 169 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/userjvmoptions/PreferencesUserJvmOptions.java (was modules/fxpackager/src/main/java/jdk/packager/services/userjvmoptions/PreferencesUserJvmOptions.java)

rev 9619 : imported patch 9-jake-fxpackager.patch
0 lines changed: 0 ins; 0 del; 0 mod; 81 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxpackagerservices/src/main/module-info/module-info.java

rev 9619 : imported patch 9-jake-fxpackager.patch
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/RuntimeFlagsParserTest.java

rev 9619 : imported patch 9-jake-fxpackager.patch
103 lines changed: 0 ins; 103 del; 0 mod; 0 unchg

This code review page was prepared using /localhome/kcr/bin/webrev (vers 25.16-hg+openjdk.java.net).