Code Review for rt

Prepared by:kcr on Mon Mar 14 19:17:32 PDT 2016
Workspace:/localhome/kcr/javafx/9/jfx/rt
Compare against: http://hg.openjdk.java.net/openjfx/9/rt
Compare against version:9618
Summary of changes: 3297 lines changed: 2453 ins; 715 del; 129 mod; 17218 unchg
Changeset: rt.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw .idea/modules.xml

rev 9619 : [mq]: 9-jake.patch
1 line changed: 1 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw apps/tests/Robot/nbproject/project.properties

rev 9619 : [mq]: 9-jake.patch
1 line changed: 1 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw apps/toys/Hello/src/main/java/hello/HelloLaunchOnNewThread.java

rev 9619 : [mq]: 9-jake.patch
8 lines changed: 8 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw build.gradle

rev 9619 : [mq]: 9-jake.patch
1022 lines changed: 677 ins; 256 del; 89 mod; 3253 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw build.properties

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 1 ins; 0 del; 3 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java

rev 9619 : [mq]: 9-jake.patch
6 lines changed: 6 ins; 0 del; 0 mod; 811 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxml/src/main/java/com/sun/javafx/fxml/BeanAdapter.java

rev 9619 : [mq]: 9-jake.patch
5 lines changed: 0 ins; 0 del; 5 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxml/src/main/java/com/sun/javafx/fxml/builder/ProxyBuilder.java

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 1 ins; 1 del; 2 mod; 659 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxml/src/main/java/com/sun/javafx/fxml/builder/URLBuilder.java

rev 9619 : [mq]: 9-jake.patch
1 line changed: 1 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxml/src/main/java/javafx/fxml/FXMLLoader.java

rev 9619 : [mq]: 9-jake.patch
3 lines changed: 3 ins; 0 del; 0 mod; 3527 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/fxml/src/main/java/javafx/fxml/JavaFXBuilderFactory.java

rev 9619 : [mq]: 9-jake.patch
3 lines changed: 0 ins; 0 del; 3 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/com/sun/glass/utils/NativeLibLoader.java

rev 9619 : [mq]: 9-jake.patch
25 lines changed: 15 ins; 3 del; 7 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java

rev 9619 : [mq]: 9-jake.patch
35 lines changed: 4 ins; 28 del; 3 mod; 988 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/com/sun/javafx/css/StyleManager.java

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 2247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/com/sun/javafx/tk/Toolkit.java

rev 9619 : [mq]: 9-jake.patch
23 lines changed: 11 ins; 10 del; 2 mod; 955 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/javafx/css/converter/URLConverter.java

rev 9619 : [mq]: 9-jake.patch
8 lines changed: 8 ins; 0 del; 0 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/javafx/scene/image/Image.java

rev 9619 : [mq]: 9-jake.patch
2 lines changed: 2 ins; 0 del; 0 mod; 1249 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/media/src/main/java/com/sun/media/jfxmedia/locator/Locator.java

rev 9619 : [mq]: 9-jake.patch
1 line changed: 0 ins; 0 del; 1 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/web/src/main/java/com/sun/webkit/LocalizedStrings.java

rev 9619 : [mq]: 9-jake.patch
39 lines changed: 0 ins; 38 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw settings.gradle

rev 9619 : [mq]: 9-jake.patch
2 lines changed: 1 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw tests/system/src/test/java/test/com/sun/javafx/css/StylesheetWithSecurityManagerTest.java

rev 9619 : [mq]: 9-jake.patch
1 line changed: 1 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw tests/system/src/test/java/test/sandbox/Constants.java

rev 9619 : [mq]: 9-jake.patch
1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw tests/system/src/test/java/test/sandbox/SandboxAppTest.java

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 0 ins; 0 del; 4 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw tests/system/src/test/java/test/util/Util.java

rev 9619 : [mq]: 9-jake.patch
73 lines changed: 66 ins; 0 del; 7 mod; 214 unchg

------ ------ ------ ------ --- New ----- Raw buildSrc/src/main/java/jarjar/org/gradle/process/internal/child/BootstrapSecurityManager.java

rev 9619 : [mq]: 9-jake.patch
68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw buildSrc/src/main/java/workaround/GradleJUnitWorker.java

rev 9619 : [mq]: 9-jake.patch
515 lines changed: 515 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw dependencies/java.base/module-info.java.extra

rev 9619 : [mq]: 9-jake.patch
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw dependencies/java.desktop/module-info.java.extra

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw dependencies/jdk.jdeps/module-info.java.extra

rev 9619 : [mq]: 9-jake.patch
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/base/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/base/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/base/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/base/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/controls/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/controls/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/controls/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/controls/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxml/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxml/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxml/src/main/java/com/sun/javafx/fxml/ModuleHelper.java

rev 9619 : [mq]: 9-jake.patch
104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxml/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/fxml/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/media/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/media/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/media/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/swing/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/swing/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/swing/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/web/make/build.properties

rev 9619 : [mq]: 9-jake.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/web/src/main/conf/security/java.policy

rev 9619 : [mq]: 9-jake.patch
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/web/src/main/module-info/module-info.java

rev 9619 : [mq]: 9-jake.patch
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/web/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw tests/system/src/test/addExports

rev 9619 : [mq]: 9-jake.patch
22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/graphics/src/main/java/netscape/javascript/JSException.java

rev 9619 : [mq]: 9-jake.patch
178 lines changed: 0 ins; 178 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/graphics/src/main/java/netscape/javascript/JSObject.java

rev 9619 : [mq]: 9-jake.patch
201 lines changed: 0 ins; 201 del; 0 mod; 0 unchg

This code review page was prepared using /localhome/kcr/bin/webrev (vers 25.16-hg+openjdk.java.net).