Code Review for jdk_sunpkcs11

Prepared by:mbalao on Mon Jun 4 19:27:31 ART 2018
Workspace:/home/martin/redhat/java/openjdk/repositories/public/jdk_sunpkcs11
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 1127 lines changed: 794 ins; 127 del; 206 mod; 14906 unchg
Patch of changes: jdk_sunpkcs11.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java

68 lines changed: 28 ins; 23 del; 17 mod; 889 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DHKeyFactory.java

14 lines changed: 10 ins; 0 del; 4 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java

14 lines changed: 10 ins; 0 del; 4 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Digest.java

8 lines changed: 6 ins; 0 del; 2 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECDHKeyAgreement.java

17 lines changed: 12 ins; 0 del; 5 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java

14 lines changed: 10 ins; 0 del; 4 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java

222 lines changed: 169 ins; 3 del; 50 mod; 1134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyAgreement.java

19 lines changed: 12 ins; 0 del; 7 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java

2 lines changed: 0 ins; 0 del; 2 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java

17 lines changed: 10 ins; 0 del; 7 mod; 2677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Mac.java

85 lines changed: 22 ins; 37 del; 26 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSACipher.java

126 lines changed: 67 ins; 37 del; 22 mod; 618 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java

21 lines changed: 15 ins; 0 del; 6 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java

9 lines changed: 6 ins; 0 del; 3 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java

87 lines changed: 32 ins; 27 del; 28 mod; 818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java

12 lines changed: 6 ins; 0 del; 6 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java

9 lines changed: 6 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java

19 lines changed: 11 ins; 0 del; 8 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

32 lines changed: 32 ins; 0 del; 0 mod; 1828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

327 lines changed: 327 ins; 0 del; 0 mod; 773 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h

1 line changed: 1 ins; 0 del; 0 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h

2 lines changed: 2 ins; 0 del; 0 mod; 473 unchg

This code review page was prepared using /home/martin/Programs/webrev.ksh (vers 25.16-hg+openjdk.java.net).