Code Review for valhalla-incubator

Prepared by:mchung on Fri Sep 15 12:06:10 PDT 2017
Workspace:/scratch/mchung/ws/valhalla/valhalla-incubator
Branch:mvt
Summary of changes: 743 lines changed: 500 ins; 81 del; 162 mod; 33861 unchg
Patch of changes: valhalla-incubator.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

2 lines changed: 2 ins; 0 del; 0 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/classfile/classFileParser.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 6453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/classfile/systemDictionary.hpp

1 line changed: 0 ins; 1 del; 0 mod; 717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/classfile/vmSymbols.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 1661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/src/share/vm/runtime/arguments.cpp

5 lines changed: 5 ins; 0 del; 0 mod; 4846 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/compiler/valhalla/valuetypes/TestBoundValueTypes.java

5 lines changed: 4 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/compiler/valhalla/valuetypes/TestUnloadedValueTypeArray.java

1 line changed: 1 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/compiler/valhalla/valuetypes/ValueCapableClass1.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/compiler/valhalla/valuetypes/ValueCapableClass2.java

4 lines changed: 2 ins; 1 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/compiler/valhalla/valuetypes/ValueTypeTestBench.java

9 lines changed: 3 ins; 1 del; 5 mod; 3334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/DeriveValueTypeCreation.java

9 lines changed: 3 ins; 4 del; 2 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/MVTCombo.java

11 lines changed: 1 ins; 7 del; 3 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/MVTComboDebugTier1.java

1 line changed: 1 ins; 0 del; 0 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/MVTComboTier1.java

1 line changed: 1 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/PersonVcc.java

1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/UninitializedValueFieldsTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/VDefaultTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/VTBufferTest.java

2 lines changed: 0 ins; 2 del; 0 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/VWithFieldTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/ValueCapableClass.java

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/ValueOops.java

5 lines changed: 4 ins; 0 del; 1 mod; 987 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/VboxUnbox.java

5 lines changed: 4 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/verifier/ValueCapableClass.java

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/verifier/VloadTest.java

5 lines changed: 2 ins; 1 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/test/runtime/valhalla/valuetypes/verifier/VunboxErrorIndex.java

4 lines changed: 3 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java

18 lines changed: 1 ins; 14 del; 3 mod; 2270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/invoke/MethodHandles.java

13 lines changed: 1 ins; 2 del; 10 mod; 5937 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/jdk/experimental/value/MethodHandleBuilder.java

5 lines changed: 1 ins; 0 del; 4 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/module-info.java

7 lines changed: 1 ins; 6 del; 0 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/valhalla/shady/MinimalValueTypes_1_0.java

136 lines changed: 119 ins; 1 del; 16 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/ConstructorTest.java

1 line changed: 0 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/Interval.java

1 line changed: 0 ins; 0 del; 1 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/MVTAccessCheck.java

1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/MVTReflectionTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/MVTTest.java

3 lines changed: 2 ins; 0 del; 1 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/MethodHandlesTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/Point.java

1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/PrivatePoint.java

1 line changed: 0 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/TestValueInValue.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/UnreflectWithersTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/WithFieldTest.java

3 lines changed: 2 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/modules/m/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/modules/m/p/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/modules/m/p/internal/Point.java

1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/point/Point.java

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/point/TestPoint.java

4 lines changed: 3 ins; 0 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/vector/Long2.java

1 line changed: 0 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/vector/VectorLibrary.java

1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/vector/VectorTest.java

1 line changed: 0 ins; 0 del; 1 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/valhalla/mvt/vector/VectorUtils.java

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java

12 lines changed: 10 ins; 0 del; 2 mod; 887 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/processing/model/TestSymtabItems.java

8 lines changed: 7 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckClone.java

4 lines changed: 0 ins; 0 del; 4 mod; 13 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckClone.out

4 lines changed: 2 ins; 1 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckCyclicMembership.java

4 lines changed: 0 ins; 0 del; 4 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckCyclicMembership.out

4 lines changed: 2 ins; 1 del; 1 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckEquals.java

3 lines changed: 0 ins; 0 del; 3 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckEquals.out

4 lines changed: 2 ins; 1 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckExtends.java

3 lines changed: 0 ins; 0 del; 3 mod; 6 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckExtends.out

3 lines changed: 1 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckFinal.java

4 lines changed: 0 ins; 0 del; 4 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckFinal.out

4 lines changed: 2 ins; 1 del; 1 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckFinalize.java

4 lines changed: 0 ins; 0 del; 4 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckFinalize.out

4 lines changed: 2 ins; 0 del; 2 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckIdentityHash.java

3 lines changed: 0 ins; 0 del; 3 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckIdentityHash.out

4 lines changed: 2 ins; 1 del; 1 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckIdentityHash01.java

3 lines changed: 0 ins; 0 del; 3 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckIdentityHash01.out

4 lines changed: 2 ins; 1 del; 1 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckNullAssign.java

3 lines changed: 0 ins; 0 del; 3 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckNullAssign.out

4 lines changed: 2 ins; 1 del; 1 mod; 6 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckNullCastable.java

3 lines changed: 0 ins; 0 del; 3 mod; 11 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckNullCastable.out

4 lines changed: 2 ins; 1 del; 1 mod; 6 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckSync.java

4 lines changed: 0 ins; 0 del; 4 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckSync.out

4 lines changed: 2 ins; 0 del; 2 mod; 18 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckSynchronized.java

3 lines changed: 0 ins; 0 del; 3 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/CheckSynchronized.out

4 lines changed: 2 ins; 1 del; 1 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/ClassFileReaderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/ClassFileReaderTest.out

3 lines changed: 1 ins; 0 del; 2 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/minimalvalues/Point.java

1 line changed: 0 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw langtools/test/tools/javac/valhalla/values/CheckNoInvokeDirect.java

4 lines changed: 2 ins; 1 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/valhalla/shady/ValueTypeHolder.java (was jdk/src/java.base/share/classes/jdk/experimental/value/ValueType.java)

43 lines changed: 1 ins; 30 del; 12 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.incubator.mvt/share/classes/jdk/incubator/mvt/ValueCapableClass.java (was jdk/src/java.base/share/classes/jvm/internal/value/ValueCapableClass.java)

4 lines changed: 3 ins; 0 del; 1 mod; 32 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.incubator.mvt/share/classes/jdk/incubator/mvt/ValueType.java

213 lines changed: 213 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.incubator.mvt/share/classes/jdk/incubator/mvt/package-info.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.incubator.mvt/share/classes/module-info.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/valhalla/mvt/TEST.properties

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).