Code Review for q-mirror

Prepared by:mchung on Tue Nov 27 08:46:09 PST 2018
Workspace:/scratch/mchung/ws/valhalla/q-mirror
Compare against: http://hg.openjdk.java.net/valhalla/valhalla
Compare against version:52848
Branch:lworld
Summary of changes: 530 lines changed: 374 ins; 19 del; 137 mod; 52038 unchg
Changeset: q-mirror.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.cpp

rev 52849 : [mq]: q-mirror-reflection
rev 52850 : imported patch method-var-handles
79 lines changed: 74 ins; 0 del; 5 mod; 4583 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.hpp

rev 52849 : [mq]: q-mirror-reflection
8 lines changed: 8 ins; 0 del; 0 mod; 1598 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.cpp

rev 52849 : [mq]: q-mirror-reflection
1 line changed: 0 ins; 0 del; 1 mod; 1057 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/instanceKlass.cpp

rev 52850 : imported patch method-var-handles
9 lines changed: 4 ins; 4 del; 1 mod; 4173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/instanceKlass.hpp

rev 52850 : imported patch method-var-handles
1 line changed: 1 ins; 0 del; 0 mod; 1620 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/valueKlass.hpp

rev 52849 : [mq]: q-mirror-reflection
5 lines changed: 5 ins; 0 del; 0 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/reflection.cpp

20 lines changed: 13 ins; 1 del; 6 mod; 1304 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/signature.cpp

rev 52849 : [mq]: q-mirror-reflection
2 lines changed: 1 ins; 0 del; 1 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

95 lines changed: 83 ins; 2 del; 10 mod; 4046 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java

3 lines changed: 2 ins; 0 del; 1 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MemberName.java

3 lines changed: 1 ins; 0 del; 2 mod; 1200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java

2 lines changed: 1 ins; 0 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java

rev 52850 : imported patch method-var-handles
3 lines changed: 0 ins; 0 del; 3 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

5 lines changed: 5 ins; 0 del; 0 mod; 2085 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/reflect/Array.java

rev 52849 : [mq]: q-mirror-reflection
5 lines changed: 0 ins; 4 del; 1 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Constructor.java

2 lines changed: 1 ins; 0 del; 1 mod; 665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Field.java

2 lines changed: 1 ins; 0 del; 1 mod; 1242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Method.java

3 lines changed: 2 ins; 0 del; 1 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Proxy.java

2 lines changed: 1 ins; 0 del; 1 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java

16 lines changed: 10 ins; 2 del; 4 mod; 2026 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/misc/Unsafe.java

rev 52850 : imported patch method-var-handles
102 lines changed: 53 ins; 3 del; 46 mod; 3808 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

rev 52850 : imported patch method-var-handles
1 line changed: 0 ins; 0 del; 1 mod; 2788 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Frame.java

rev 52850 : imported patch method-var-handles
2 lines changed: 2 ins; 0 del; 0 mod; 1595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java

rev 52850 : imported patch method-var-handles
2 lines changed: 1 ins; 0 del; 1 mod; 2401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Type.java

12 lines changed: 9 ins; 1 del; 2 mod; 931 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java

rev 52850 : imported patch method-var-handles
1 line changed: 1 ins; 0 del; 0 mod; 978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java

1 line changed: 1 ins; 0 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java

1 line changed: 1 ins; 0 del; 0 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java

rev 52850 : imported patch method-var-handles
1 line changed: 0 ins; 0 del; 1 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java

rev 52850 : imported patch method-var-handles
1 line changed: 0 ins; 0 del; 1 mod; 1063 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java

rev 52850 : imported patch method-var-handles
1 line changed: 1 ins; 0 del; 0 mod; 1581 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/AccessorGenerator.java

5 lines changed: 4 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java

7 lines changed: 3 ins; 0 del; 4 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/VerifyAccess.java

2 lines changed: 0 ins; 0 del; 2 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/Class.c

rev 52849 : [mq]: q-mirror-reflection
2 lines changed: 0 ins; 0 del; 2 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java

1 line changed: 0 ins; 0 del; 1 mod; 1972 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestMethodHandles.java

10 lines changed: 0 ins; 0 del; 10 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNativeClone.java

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ObjectMethods.java

rev 52849 : [mq]: q-mirror-reflection
rev 52850 : imported patch method-var-handles
0 lines changed: 0 ins; 0 del; 0 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java

rev 52849 : [mq]: q-mirror-reflection
5 lines changed: 3 ins; 0 del; 2 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/valhalla/valuetypes/MethodHandleTest.java

rev 52850 : imported patch method-var-handles
3 lines changed: 0 ins; 2 del; 1 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/valhalla/valuetypes/MixedValues.java

rev 52850 : imported patch method-var-handles
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/valhalla/valuetypes/NonFlattenValue.java

rev 52849 : [mq]: q-mirror-reflection
rev 52850 : imported patch method-var-handles
8 lines changed: 7 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/Reflection.java

79 lines changed: 73 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/valhalla/valuetypes/QTypeDescriptorTest.java (was test/jdk/valhalla/valuetypes/ValueTypesAttributeTest.java)

rev 52850 : imported patch method-var-handles
15 lines changed: 2 ins; 0 del; 13 mod; 145 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).