Code Review for rt

Prepared by:nlisker on Sat May 19 16:28:57 IDT 2018
Workspace:/cygdrive/d/dev/openjfx/11-dev/rt
Summary of changes: 867 lines changed: 143 ins; 195 del; 529 mod; 18070 unchg
Patch of changes: rt.patch
Bug id: JDK-8195974
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/binding/Logging.java

76 lines changed: 72 ins; 0 del; 4 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/logging/PlatformLogger.java

2 lines changed: 0 ins; 1 del; 1 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/module-info.java

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ErrorLoggingUtiltity.java

60 lines changed: 11 ins; 26 del; 23 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java

3 lines changed: 0 ins; 1 del; 2 mod; 651 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/test/java/test/javafx/binding/BindingsCreateBindingTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/ToggleButtonTest.java

9 lines changed: 1 ins; 6 del; 2 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/java/javafx/fxml/JavaFXBuilderFactory.java

7 lines changed: 1 ins; 2 del; 4 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.fxml/src/main/java/module-info.java

2 lines changed: 0 ins; 2 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/android/java/com/sun/javafx/sg/prism/NGWebView.java

3 lines changed: 0 ins; 0 del; 3 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/sg/prism/web/NGWebView.java

6 lines changed: 0 ins; 1 del; 5 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/InputMethodClientImpl.java

10 lines changed: 1 ins; 3 del; 6 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/drt/DumpRenderTree.java

17 lines changed: 3 ins; 6 del; 8 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCFontImpl.java

10 lines changed: 2 ins; 2 del; 6 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java

25 lines changed: 2 ins; 4 del; 19 mod; 1810 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCImageDecoderImpl.java

6 lines changed: 2 ins; 2 del; 2 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCImageImpl.java

9 lines changed: 2 ins; 2 del; 5 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCMediaPlayerImpl.java

52 lines changed: 1 ins; 18 del; 33 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCPathImpl.java

29 lines changed: 0 ins; 4 del; 25 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/theme/ContextMenuImpl.java

10 lines changed: 0 ins; 3 del; 7 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/theme/PopupMenuImpl.java

11 lines changed: 0 ins; 4 del; 7 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/theme/RenderThemeImpl.java

9 lines changed: 2 ins; 3 del; 4 mod; 585 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/javafx/webkit/theme/ScrollBarThemeImpl.java

7 lines changed: 1 ins; 2 del; 4 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/ColorChooser.java

3 lines changed: 0 ins; 3 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/EventLoop.java

5 lines changed: 0 ins; 1 del; 4 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/FileSystem.java

11 lines changed: 1 ins; 5 del; 5 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/LocalizedStrings.java

8 lines changed: 1 ins; 2 del; 5 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/WCPasteboard.java

8 lines changed: 0 ins; 1 del; 7 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/WCPluginWidget.java

6 lines changed: 1 ins; 2 del; 3 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/WCWidget.java

12 lines changed: 2 ins; 2 del; 8 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/WatchdogTimer.java

6 lines changed: 1 ins; 2 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java

190 lines changed: 2 ins; 14 del; 174 mod; 2485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/graphics/GraphicsDecoder.java

5 lines changed: 2 ins; 1 del; 2 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/graphics/WCGraphicsManager.java

8 lines changed: 1 ins; 4 del; 3 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/graphics/WCMediaPlayer.java

43 lines changed: 0 ins; 20 del; 23 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/graphics/WCRenderQueue.java

8 lines changed: 2 ins; 2 del; 4 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/Cookie.java

12 lines changed: 2 ins; 2 del; 8 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/CookieManager.java

18 lines changed: 3 ins; 2 del; 13 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/CookieStore.java

13 lines changed: 3 ins; 3 del; 7 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/DateParser.java

10 lines changed: 3 ins; 3 del; 4 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/NetworkContext.java

8 lines changed: 2 ins; 2 del; 4 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/PublicSuffixes.java

14 lines changed: 3 ins; 3 del; 8 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/SocketStreamHandle.java

43 lines changed: 2 ins; 12 del; 29 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/network/URLLoader.java

18 lines changed: 2 ins; 2 del; 14 mod; 1006 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/perf/PerfLogger.java

10 lines changed: 2 ins; 2 del; 6 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/perf/WCFontPerfLogger.java

4 lines changed: 0 ins; 1 del; 3 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/perf/WCGraphicsPerfLogger.java

3 lines changed: 1 ins; 1 del; 1 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/plugin/DefaultPlugin.java

4 lines changed: 1 ins; 1 del; 2 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/com/sun/webkit/plugin/PluginManager.java

6 lines changed: 1 ins; 2 del; 3 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/javafx/scene/web/DirectoryLock.java

9 lines changed: 1 ins; 2 del; 6 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/javafx/scene/web/WebEngine.java

14 lines changed: 1 ins; 5 del; 8 mod; 1604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.web/src/main/java/module-info.java

1 line changed: 0 ins; 1 del; 0 mod; 48 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).