Code Review for jdk-8196989-2

Prepared by:phh on Thu Oct 18 18:02:25 EDT 2018
Workspace:/Users/hohensee/unix.sparsebundle/workspaces/jdk-8196989-2
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 811 lines changed: 512 ins; 56 del; 243 mod; 14810 unchg
Patch of changes: jdk-8196989-2.patch
Bug id: JDK-8196989 : Revamp G1 JMX MemoryPool and GarbageCollector MXBean definitions
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

8 lines changed: 3 ins; 3 del; 2 mod; 4673 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

5 lines changed: 0 ins; 1 del; 4 mod; 1422 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

8 lines changed: 8 ins; 0 del; 0 mod; 3059 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCScope.cpp

1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryPool.cpp

27 lines changed: 22 ins; 0 del; 5 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryPool.hpp

61 lines changed: 33 ins; 12 del; 16 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MonitoringSupport.cpp

236 lines changed: 145 ins; 22 del; 69 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MonitoringSupport.hpp

95 lines changed: 51 ins; 6 del; 38 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1_globals.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/vmStructs_g1.hpp

7 lines changed: 5 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.cpp

5 lines changed: 4 ins; 0 del; 1 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1MonitoringSupport.java

58 lines changed: 47 ins; 0 del; 11 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java

22 lines changed: 10 ins; 7 del; 5 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestMemoryMXBeansAndPoolsPresence.java

17 lines changed: 14 ins; 0 del; 3 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/arguments/GCTypes.java

26 lines changed: 22 ins; 1 del; 3 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/mixedgc/TestOldGenCollectionUsage.java

63 lines changed: 28 ins; 0 del; 35 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithG1.java

17 lines changed: 13 ins; 0 del; 4 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/survivorAlignment/SurvivorAlignmentTestMain.java

4 lines changed: 2 ins; 0 del; 2 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java

2 lines changed: 1 ins; 0 del; 1 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java

2 lines changed: 1 ins; 0 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest.java

35 lines changed: 27 ins; 1 del; 7 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/MemoryManagement.java

31 lines changed: 23 ins; 1 del; 7 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/MemoryTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/MemoryTestAllGC.sh

2 lines changed: 0 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java

33 lines changed: 19 ins; 2 del; 12 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/jfr/event/gc/detailed/PromotionEvent.java

3 lines changed: 1 ins; 0 del; 2 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/jfr/event/gc/stacktrace/AllocationStackTrace.java

29 lines changed: 22 ins; 0 del; 7 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/jfr/GCHelper.java

6 lines changed: 6 ins; 0 del; 0 mod; 467 unchg

This code review page was prepared using /Users/hohensee/bin/webrev (vers 25.16-hg+openjdk.java.net).