Code Review for hotspot

Prepared by:pliden on Fri Apr 10 16:20:02 CEST 2015
Workspace:/home/pliden/openjdk/repos/bugs/hs-gc/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk9/hs-gc/hotspot
Compare against version:8067
Summary of changes: 254 lines changed: 16 ins; 93 del; 145 mod; 40755 unchg
Changeset: hotspot.changeset
Bug id: JDK-8077413 : Avoid use of Universe::heap() inside collectors
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

rev 8070 : imported patch gencollected_heap_cleanup
5 lines changed: 0 ins; 2 del; 3 mod; 8535 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp

rev 8070 : imported patch gencollected_heap_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 8069 : imported patch g1_cleanup
6 lines changed: 0 ins; 0 del; 6 mod; 4687 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp

rev 8069 : imported patch g1_cleanup
6 lines changed: 1 ins; 0 del; 5 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 8069 : imported patch g1_cleanup
2 lines changed: 2 ins; 0 del; 0 mod; 6592 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1MarkSweep.cpp

rev 8069 : imported patch g1_cleanup
8 lines changed: 0 ins; 5 del; 3 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp

rev 8069 : imported patch g1_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1ParScanThreadState.inline.hpp

rev 8069 : imported patch g1_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp

rev 8069 : imported patch g1_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp

rev 8069 : imported patch g1_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1StringDedupQueue.cpp

rev 8069 : imported patch g1_cleanup
2 lines changed: 1 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1StringDedupTable.cpp

rev 8069 : imported patch g1_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp

rev 8070 : imported patch gencollected_heap_cleanup
3 lines changed: 1 ins; 1 del; 1 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parNew/parNewGeneration.cpp

rev 8070 : imported patch gencollected_heap_cleanup
11 lines changed: 0 ins; 4 del; 7 mod; 1489 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parNew/parOopClosures.inline.hpp

rev 8070 : imported patch gencollected_heap_cleanup
2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp

rev 8068 : imported patch parallelscavenge_cleanup
2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp

rev 8068 : imported patch parallelscavenge_cleanup
10 lines changed: 0 ins; 4 del; 6 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp

rev 8068 : imported patch parallelscavenge_cleanup
11 lines changed: 0 ins; 6 del; 5 mod; 690 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp

rev 8068 : imported patch parallelscavenge_cleanup
8 lines changed: 1 ins; 2 del; 5 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp

rev 8068 : imported patch parallelscavenge_cleanup
8 lines changed: 0 ins; 0 del; 8 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp

rev 8068 : imported patch parallelscavenge_cleanup
2 lines changed: 0 ins; 1 del; 1 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp

rev 8068 : imported patch parallelscavenge_cleanup
19 lines changed: 0 ins; 10 del; 9 mod; 662 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp

rev 8068 : imported patch parallelscavenge_cleanup
5 lines changed: 0 ins; 3 del; 2 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp

rev 8068 : imported patch parallelscavenge_cleanup
14 lines changed: 2 ins; 2 del; 10 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

rev 8068 : imported patch parallelscavenge_cleanup
15 lines changed: 0 ins; 4 del; 11 mod; 3432 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp

rev 8068 : imported patch parallelscavenge_cleanup
6 lines changed: 1 ins; 5 del; 0 mod; 1503 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.inline.hpp

rev 8068 : imported patch parallelscavenge_cleanup
4 lines changed: 1 ins; 0 del; 3 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.cpp

rev 8068 : imported patch parallelscavenge_cleanup
7 lines changed: 1 ins; 4 del; 2 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp

rev 8068 : imported patch parallelscavenge_cleanup
11 lines changed: 0 ins; 5 del; 6 mod; 452 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp

rev 8068 : imported patch parallelscavenge_cleanup
6 lines changed: 1 ins; 2 del; 3 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

rev 8068 : imported patch parallelscavenge_cleanup
18 lines changed: 1 ins; 10 del; 7 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp

rev 8068 : imported patch parallelscavenge_cleanup
3 lines changed: 0 ins; 1 del; 2 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp

rev 8068 : imported patch parallelscavenge_cleanup
6 lines changed: 0 ins; 2 del; 4 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp

rev 8068 : imported patch parallelscavenge_cleanup
13 lines changed: 0 ins; 5 del; 8 mod; 945 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp

rev 8068 : imported patch parallelscavenge_cleanup
5 lines changed: 0 ins; 3 del; 2 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/cardGeneration.cpp

rev 8070 : imported patch gencollected_heap_cleanup
3 lines changed: 0 ins; 0 del; 3 mod; 357 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/cardTableRS.cpp

rev 8070 : imported patch gencollected_heap_cleanup
8 lines changed: 0 ins; 5 del; 3 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/collectorPolicy.cpp

rev 8070 : imported patch gencollected_heap_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 1101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/defNewGeneration.cpp

rev 8070 : imported patch gencollected_heap_cleanup
7 lines changed: 2 ins; 0 del; 5 mod; 1058 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/defNewGeneration.inline.hpp

rev 8070 : imported patch gencollected_heap_cleanup
4 lines changed: 1 ins; 1 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/generation.cpp

rev 8070 : imported patch gencollected_heap_cleanup
1 line changed: 0 ins; 0 del; 1 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/instanceRefKlass.cpp

rev 8070 : imported patch gencollected_heap_cleanup
6 lines changed: 0 ins; 6 del; 0 mod; 135 unchg

This code review page was prepared using /home/pliden/openjdk/tools/webrev/webrev/webrev.ksh (vers 25.6-hg+openjdk.java.net).