Code Review for hotspot

Prepared by:rbackman on Fri Oct 18 10:43:27 CEST 2013
Workspace:/home/rbackman/code/hs-comp-tip/hotspot
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot
Compare against version:5461
Summary of changes: 3076 lines changed: 2859 ins; 133 del; 84 mod; 54891 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/sparc.ad 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
4 lines changed: 4 ins; 0 del; 0 mod; 10948 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/x86_32.ad 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
95 lines changed: 93 ins; 0 del; 2 mod; 13190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/x86_64.ad 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
206 lines changed: 206 ins; 0 del; 0 mod; 11576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/adlc/archDesc.cpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
7 lines changed: 7 ins; 0 del; 0 mod; 1211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
16 lines changed: 15 ins; 0 del; 1 mod; 1221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/classes.hpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
9 lines changed: 9 ins; 0 del; 0 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
165 lines changed: 151 ins; 1 del; 13 mod; 5867 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.hpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/mathexactnode.cpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
300 lines changed: 281 ins; 8 del; 11 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/mathexactnode.hpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
71 lines changed: 68 ins; 0 del; 3 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.cpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
6 lines changed: 6 ins; 0 del; 0 mod; 4623 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.hpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 1636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
7 lines changed: 6 ins; 0 del; 1 mod; 3314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/Verify.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
673 lines changed: 631 ins; 38 del; 4 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactICondTest.java (was test/compiler/intrinsics/mathexact/CondTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
5 lines changed: 0 ins; 2 del; 3 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactIConstantTest.java (was test/compiler/intrinsics/mathexact/ConstantTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
14 lines changed: 0 ins; 10 del; 4 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactILoadTest.java (was test/compiler/intrinsics/mathexact/LoadTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
22 lines changed: 0 ins; 17 del; 5 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactILoopDependentTest.java (was test/compiler/intrinsics/mathexact/LoopDependentTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
15 lines changed: 0 ins; 11 del; 4 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactINonConstantTest.java (was test/compiler/intrinsics/mathexact/NonConstantTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
15 lines changed: 0 ins; 11 del; 4 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/intrinsics/mathexact/AddExactIRepeatTest.java (was test/compiler/intrinsics/mathexact/RepeatTest.java) 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
101 lines changed: 37 ins; 35 del; 29 mod; 43 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/AddExactLConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/AddExactLNonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/DecExactITest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/DecExactLTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/IncExactITest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/IncExactLTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactICondTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactIConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactILoadTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactILoopDependentTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactINonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactIRepeatTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactLConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/MulExactLNonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactIConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactILoadTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactILoopDependentTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactINonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactLConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/NegExactLNonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactICondTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactIConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactILoadTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactILoopDependentTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactINonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactIRepeatTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactLConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java 

rev 5462 : 8026844: Various Math functions needs intrinsification
Reviewed-by: duke
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rbackman/bin/webrev (vers 23.18-hg-never).