Code Review for open

Prepared by:rehn on Mon Jun 4 17:08:56 CEST 2018
Workspace:/home/rehn/source/jdk/hashish-jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:50372
Summary of changes: 1279 lines changed: 450 ins; 381 del; 448 mod; 33363 unchg
Changeset: open.changeset
Bug id: JDK-8195097 : Make it possible to process StringTable outside safepoint
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/stringTable.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
rev 50374 : imported patch 8195097-stringtable-robbin
rev 50375 : [mq]: 8195097-stringtable-v2
779 lines changed: 271 ins; 154 del; 354 mod; 248 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/stringTable.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
rev 50374 : imported patch 8195097-stringtable-robbin
rev 50375 : [mq]: 8195097-stringtable-v2
149 lines changed: 46 ins; 62 del; 41 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 1 ins; 0 del; 2 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
9 lines changed: 6 ins; 0 del; 3 mod; 8114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
5 lines changed: 3 ins; 0 del; 2 mod; 1458 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
11 lines changed: 3 ins; 6 del; 2 mod; 4966 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1RootProcessor.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1RootProcessor.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
rev 50375 : [mq]: 8195097-stringtable-v2
14 lines changed: 8 ins; 0 del; 6 mod; 1405 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
7 lines changed: 4 ins; 0 del; 3 mod; 502 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/strongRootsScope.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 0 ins; 2 del; 0 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspaceShared.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 2171 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
6 lines changed: 6 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
4 lines changed: 2 ins; 1 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.inline.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
6 lines changed: 6 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/globals.hpp

rev 50375 : [mq]: 8195097-stringtable-v2
3 lines changed: 1 ins; 0 del; 2 mod; 2802 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/java.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
rev 50375 : [mq]: 8195097-stringtable-v2
7 lines changed: 0 ins; 5 del; 2 mod; 748 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
5 lines changed: 5 ins; 0 del; 0 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/serviceThread.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 7 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 0 ins; 8 del; 0 mod; 3177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/concurrentHashTable.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 3 ins; 0 del; 0 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/concurrentHashTable.inline.hpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
72 lines changed: 28 ins; 20 del; 24 mod; 1172 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp

rev 50375 : [mq]: 8195097-stringtable-v2
2 lines changed: 2 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/globalDefinitions.hpp

rev 50375 : [mq]: 8195097-stringtable-v2
2 lines changed: 0 ins; 0 del; 2 mod; 1271 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 0 ins; 8 del; 0 mod; 972 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
38 lines changed: 0 ins; 38 del; 0 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/gtest/utilities/test_concurrentHashtable.cpp

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
38 lines changed: 38 ins; 0 del; 0 mod; 917 unchg

------ ------ ------ ------ Old --- ----- --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/StringTable.java

rev 50373 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

This code review page was prepared using /home/rehn/source/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).