Code Review for jdk

Prepared by:sherman on Fri Oct 30 14:04:26 PDT 2015
Workspace:/export/home/xueshen/sandbox/jdk
Compare against: http://hg.openjdk.java.net/jdk9/sandbox/jdk
Summary of changes: 9437 lines changed: 8148 ins; 773 del; 516 mod; 19837 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/String.java

1178 lines changed: 345 ins; 619 del; 214 mod; 2568 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/StringLatin1.java

600 lines changed: 600 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/StringUTF16.java

971 lines changed: 971 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StringCoding.java

442 lines changed: 325 ins; 63 del; 54 mod; 287 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/StringDecoderUTF8.java

235 lines changed: 235 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/AbstractStringBuilder.java

490 lines changed: 301 ins; 58 del; 131 mod; 1287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StringBuffer.java

28 lines changed: 13 ins; 6 del; 9 mod; 714 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StringBuilder.java

11 lines changed: 8 ins; 0 del; 3 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Integer.java

118 lines changed: 96 ins; 4 del; 18 mod; 1727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Long.java

132 lines changed: 110 ins; 5 del; 17 mod; 1847 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/ArrayDecoder.java

4 lines changed: 4 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/ArrayEncoder.java

15 lines changed: 14 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/DoubleByte.java

193 lines changed: 175 ins; 2 del; 16 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/HKSCS.java

29 lines changed: 27 ins; 0 del; 2 mod; 431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/ISO_8859_1.java

8 lines changed: 8 ins; 0 del; 0 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/SingleByte.java

62 lines changed: 61 ins; 0 del; 1 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/US_ASCII.java

8 lines changed: 8 ins; 0 del; 0 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/UTF_8.java

8 lines changed: 8 ins; 0 del; 0 mod; 746 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/nio/cs/StringUTF16.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_Solaris.java.template

2 lines changed: 0 ins; 0 del; 2 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM834.java

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Arrays.java

1 line changed: 1 ins; 0 del; 0 mod; 5188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/String.c

11 lines changed: 11 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/mapfile-vers

1 line changed: 1 ins; 0 del; 0 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/reorder-sparc

1 line changed: 1 ins; 0 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/reorder-sparcv9

1 line changed: 1 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/reorder-x86

1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/charsetmapping/DoubleByte-X.java.template

2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/charsetmapping/SingleByte-X.java.template

2 lines changed: 0 ins; 0 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/DBCS.java

1 line changed: 1 ins; 0 del; 0 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/SBCS.java

3 lines changed: 3 ins; 0 del; 0 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/nio/cs/TestStringCoding.java

94 lines changed: 48 ins; 15 del; 31 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/nio/cs/TestStringCodingUTF8.java

13 lines changed: 12 ins; 0 del; 1 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/String/LiteralReplace.java

104 lines changed: 103 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/String/ToLowerCase.java

48 lines changed: 46 ins; 0 del; 2 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/String/ToUpperCase.java

54 lines changed: 52 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/StringBuffer/Exceptions.java

3 lines changed: 0 ins; 0 del; 3 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/StringBuilder/BuilderForwarding.java

1 line changed: 0 ins; 1 del; 0 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/StringBuilder/Exceptions.java

3 lines changed: 0 ins; 0 del; 3 mod; 120 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/Chars.java

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CharAt.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CodePointAt.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CodePointBefore.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CodePointCount.java

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CompactString.java

307 lines changed: 307 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CompareTo.java

94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/CompareToIgnoreCase.java

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Concat.java

132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Contains.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/EndsWith.java

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Equals.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/EqualsIgnoreCase.java

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/GetChars.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/IndexOf.java

249 lines changed: 249 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Intern.java

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/LastIndexOf.java

225 lines changed: 225 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Length.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Numbers.java

106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/OffsetByCodePoints.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/RegionMatches.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Replace.java

117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/SerializationTest.java

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Split.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/StartsWith.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/SubString.java

84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/ToCharArray.java

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/ToLowerCase.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/ToUpperCase.java

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/Trim.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/String/CompactString/ValueOf.java

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/StringBuffer/CompactStringBuffer.java

489 lines changed: 489 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/StringBuffer/CompactStringBufferSerialization.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/StringBuilder/CompactStringBuilder.java

414 lines changed: 414 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/StringBuilder/CompactStringBuilderSerialization.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/testlibrary/jdk/testlibrary/SerializationUtils.java

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).