Code Review for base64

Prepared by: U-AMR\skamath4 (skamath4) on Thu Jun 21 22:32:45 PDT 2018
Workspace:/home/skamath4/base64
Summary of changes: 753 lines changed: 730 ins; 10 del; 13 mod; 58522 unchg
Patch of changes: base64.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.cpp

131 lines changed: 126 ins; 1 del; 4 mod; 9016 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.hpp

56 lines changed: 48 ins; 1 del; 7 mod; 2242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

9 lines changed: 9 ins; 0 del; 0 mod; 11002 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

6 lines changed: 6 ins; 0 del; 0 mod; 1752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

411 lines changed: 411 ins; 0 del; 0 mod; 5155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubRoutines_x86.cpp

9 lines changed: 9 ins; 0 del; 0 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubRoutines_x86.hpp

15 lines changed: 15 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/vm_version_x86.cpp

11 lines changed: 11 ins; 0 del; 0 mod; 1583 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCodeHeap.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1051 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

3 lines changed: 3 ins; 0 del; 0 mod; 1052 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

6 lines changed: 6 ins; 0 del; 0 mod; 1633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

1 line changed: 1 ins; 0 del; 0 mod; 993 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

1 line changed: 1 ins; 0 del; 0 mod; 606 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

1 line changed: 1 ins; 0 del; 0 mod; 3537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

32 lines changed: 32 ins; 0 del; 0 mod; 7000 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

21 lines changed: 21 ins; 0 del; 0 mod; 1665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.hpp

1 line changed: 1 ins; 0 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 3131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.cpp

1 line changed: 1 ins; 0 del; 0 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.hpp

2 lines changed: 1 ins; 0 del; 1 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

1 line changed: 1 ins; 0 del; 0 mod; 3194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Base64.java

30 lines changed: 21 ins; 8 del; 1 mod; 1040 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/BinaryContainer.java

1 line changed: 1 ins; 0 del; 0 mod; 905 unchg

This code review page was prepared using /home/skamath4/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).