Code Review for hotspot

Prepared by:iklam on Tue Aug 12 23:08:22 PDT 2014
Workspace:/jdk/jdk9/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk9/hs-rt/hotspot
Compare against version:qparent
Summary of changes: 2220 lines changed: 1794 ins; 140 del; 286 mod; 53160 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/excludeSrc.make

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 1 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/os/linux/vm/os_linux.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 1 ins; 0 del; 1 mod; 6180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
37 lines changed: 36 ins; 0 del; 1 mod; 5234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoader.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
288 lines changed: 218 ins; 19 del; 51 mod; 1345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoader.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
33 lines changed: 25 ins; 0 del; 8 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
46 lines changed: 34 ins; 3 del; 9 mod; 748 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
4 lines changed: 1 ins; 2 del; 1 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
59 lines changed: 41 ins; 2 del; 16 mod; 2785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
30 lines changed: 19 ins; 2 del; 9 mod; 673 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
15 lines changed: 15 ins; 0 del; 0 mod; 1259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/allocation.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 1 ins; 0 del; 1 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/filemap.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
288 lines changed: 176 ins; 35 del; 77 mod; 469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/filemap.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
109 lines changed: 79 ins; 18 del; 12 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metadataFactory.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
6 lines changed: 6 ins; 0 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspace.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
73 lines changed: 59 ins; 2 del; 12 mod; 3812 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspace.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 1 ins; 0 del; 1 mod; 431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspaceShared.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
253 lines changed: 141 ins; 54 del; 58 mod; 889 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspaceShared.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
16 lines changed: 15 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/universe.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
15 lines changed: 14 ins; 0 del; 1 mod; 1500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/arrayKlass.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
3 lines changed: 1 ins; 0 del; 2 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/arrayKlass.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
1 line changed: 0 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
38 lines changed: 34 ins; 0 del; 4 mod; 3744 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
8 lines changed: 7 ins; 0 del; 1 mod; 1302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/klass.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
7 lines changed: 2 ins; 2 del; 3 mod; 717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/klass.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
20 lines changed: 19 ins; 0 del; 1 mod; 668 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvm.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
13 lines changed: 12 ins; 0 del; 1 mod; 4355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
63 lines changed: 57 ins; 1 del; 5 mod; 4047 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
7 lines changed: 3 ins; 0 del; 4 mod; 592 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
27 lines changed: 27 ins; 0 del; 0 mod; 3948 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/javaCalls.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
4 lines changed: 4 ins; 0 del; 0 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 1 ins; 0 del; 1 mod; 3364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/exceptions.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
10 lines changed: 8 ins; 0 del; 2 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/ostream.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
18 lines changed: 17 ins; 0 del; 1 mod; 1321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/ostream.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
2 lines changed: 2 ins; 0 del; 0 mod; 327 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/classfile/classLoaderExt.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/classfile/sharedClassUtil.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/classfile/sharedPathsMiscInfo.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/classfile/sharedPathsMiscInfo.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/classfile/systemDictionaryShared.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/stringUtils.cpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/utilities/stringUtils.hpp

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/testlibrary/com/oracle/java/testlibrary/BuildHelper.java

rev 6853 : 8046070: Class Data Sharing clean up and refactoring
Summary: Cleaned up CDS to be more configurable, maintainable and extensible
Reviewed-by: dholmes, coleenp, acorn, mchung
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/iklam/jdk/webrev.ksh (vers 25.2-hg+openjdk.java.net).