Code Review for open

Prepared by:iklam on Wed Aug 12 15:02:06 PDT 2020
Workspace:/jdk2/gil/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:bb06fa718a9a
Summary of changes: 1634 lines changed: 1502 ins; 24 del; 108 mod; 52568 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/lib/JvmFeatures.gmk

1 line changed: 1 ins; 0 del; 0 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/symbols/symbols-unix

1 line changed: 1 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.cpp

7 lines changed: 3 ins; 1 del; 3 mod; 1707 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 970 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

7 lines changed: 5 ins; 1 del; 1 mod; 4924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

1 line changed: 1 ins; 0 del; 0 mod; 1715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/moduleEntry.cpp

189 lines changed: 186 ins; 0 del; 3 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/moduleEntry.hpp

26 lines changed: 24 ins; 0 del; 2 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.cpp

24 lines changed: 24 ins; 0 del; 0 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.hpp

4 lines changed: 3 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/packageEntry.cpp

114 lines changed: 112 ins; 1 del; 1 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/packageEntry.hpp

14 lines changed: 14 ins; 0 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 3048 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 722 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 1716 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

8 lines changed: 8 ins; 0 del; 0 mod; 1277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.cpp

7 lines changed: 6 ins; 0 del; 1 mod; 2290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.hpp

1 line changed: 1 ins; 0 del; 0 mod; 594 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapShared.cpp

97 lines changed: 83 ins; 0 del; 14 mod; 1084 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapShared.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

55 lines changed: 49 ins; 5 del; 1 mod; 2693 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.hpp

17 lines changed: 12 ins; 1 del; 4 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 4190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

1 line changed: 1 ins; 0 del; 0 mod; 1494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

5 lines changed: 5 ins; 0 del; 0 mod; 4040 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

9 lines changed: 7 ins; 0 del; 2 mod; 4391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

11 lines changed: 11 ins; 0 del; 0 mod; 2750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Module.java

48 lines changed: 44 ins; 0 del; 4 mod; 1674 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

3 lines changed: 3 ins; 0 del; 0 mod; 2299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/SecureClassLoader.java

8 lines changed: 7 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java

6 lines changed: 6 ins; 0 del; 0 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/BootLoader.java

9 lines changed: 8 ins; 0 del; 1 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java

42 lines changed: 37 ins; 2 del; 3 mod; 1040 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java

38 lines changed: 24 ins; 3 del; 11 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/VM.java

2 lines changed: 2 ins; 0 del; 0 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ArchivedModuleGraph.java

29 lines changed: 14 ins; 3 del; 12 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/IllegalAccessLogger.java

3 lines changed: 0 ins; 0 del; 3 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java

98 lines changed: 62 ins; 7 del; 29 mod; 1040 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java

10 lines changed: 10 ins; 0 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/VM.c

7 lines changed: 7 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java

22 lines changed: 21 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/SpecifySysLoaderProp.java

3 lines changed: 2 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/logging/ModulesTest.java

9 lines changed: 5 ins; 0 del; 4 mod; 72 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/classfile/classLoaderDataShared.cpp

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/classfile/classLoaderDataShared.hpp

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/loader/ArchivedClassLoaders.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/module/ArchivedBootLayer.java

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/NMT/src/jdk.test/module-info.java

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/NMT/src/jdk.test/test/Main.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/cds/ServiceLoaderTest.java

132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/jigsaw/NewModuleFinderTest.java

99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/iklam/jdk/proj/ioisvn/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).